Fix negative hh_mm_ss components by pauldreik · Pull Request #118 · pauldreik/psychicstd

pauldreik · 2026-07-31T07:27:41Z

Summary

return non-negative hour, minute, and second components for negative durations
use an overflow-safe magnitude calculation
add focused chrono regression coverage

Tests

test_chrono_system
test_chrono_psychicstd
Clang ASan variants of both tests
chrono compliance sanitizer subset

The full local sanitizer subset also encountered environment-specific LeakSanitizer ptrace aborts in unrelated tests.

Return non-negative hour, minute, and second components for negative durations. Use an overflow-safe magnitude calculation and cover the behavior with a focused chrono regression test.

github-actions · 2026-07-31T07:28:33Z

Compile-time performance diff

Compiler: g++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 5 per configuration.

psychicstd compile time, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 2.3%.

🔴 1 slower · 🟡 2 within noise.

benchmark	main	PR	Δ (95% CI)	vs system
`wordcounter`	174.6ms	184.3ms	🔴 +5.5% [+4.5, +6.8]	3.2x

🟡 2 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`all-headers`	212.3ms	214.6ms	🟡 +1.1% [-0.1, +3.1]	6.9x
`iostream`	75.4ms	78.3ms	🟡 +3.8% [-57.6, +5.1]	3.6x

Reproduce this on your machine: scripts/compare_compile_time_to_ref.py --reps 5 g++ origin/main

github-actions · 2026-07-31T07:29:52Z

rdfind build-time diff (configure / compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 5 per configuration.

rdfind build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 0.1%.

No significant changes (🟡 3 within noise).

🟡 3 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	481.5ms	480.0ms	🟡 -0.3% [-5.4, +1.7]	4.1x
`configure`	1239.5ms	1239.5ms	🟡 +0.0% [-0.8, +1.7]	1.0x
`run tests`	1606.0ms	1603.1ms	🟡 -0.2% [-3.3, +0.5]	1.0x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py rdfind --build-type debug --reps 5

github-actions · 2026-07-31T07:30:18Z

flatbuffers build-time diff (configure / compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 1 per configuration.

flatbuffers build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 52.2%.

No significant changes (🟡 3 within noise).

🟡 3 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	20294.9ms	20377.9ms	🟡 +0.4%	2.3x
`configure`	474.0ms	472.6ms	🟡 -0.3%	1.0x
`run tests`	90.5ms	91.2ms	🟡 +0.8%	1.2x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py flatbuffers --build-type debug --reps 1

github-actions · 2026-07-31T07:33:22Z

eigen build-time diff (compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 2 per configuration.

eigen build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 1.4%.

No significant changes (🟡 2 within noise).

🟡 2 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	17599.4ms	17642.1ms	🟡 +0.2% [-1.1, +1.6]	1.7x
`run tests`	37.1ms	38.3ms	🟡 +3.1% [+1.5, +4.8]	1.3x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py eigen --build-type debug --reps 2

github-actions · 2026-07-31T07:35:00Z

simdutf build-time diff (compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 1 per configuration.

simdutf build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 3.7%.

No significant changes (🟡 2 within noise).

🟡 2 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	17027.2ms	17239.7ms	🟡 +1.2%	2.1x
`run tests`	51608.1ms	50140.6ms	🟡 -2.8%	1.0x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py simdutf --build-type debug --reps 1

github-actions · 2026-07-31T07:35:33Z

fmt build-time diff (compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 2 per configuration.

fmt build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 21.7%.

No significant changes (🟡 2 within noise).

🟡 2 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	32465.8ms	32171.6ms	🟡 -0.9% [-1.4, -0.4]	1.6x
`run tests`	220.4ms	214.6ms	🟡 -2.6% [-3.1, -2.2]	1.7x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py fmt --build-type debug --reps 2

github-actions · 2026-07-31T07:37:09Z

Sanitizer diff (ASan/UBSan)

No changes detected.

72 header(s) unchanged

header	passes/sampled
`algorithm`	4/25
`any`	6/18
`array`	17/25
`atomic`	12/25
`bit`	2/15
`bitset`	3/25
`cassert`	3/9
`cctype`	2/5
`cerrno`	4/25
`cfloat`	4/25
`chrono`	0/25
`ciso646`	4/25
`climits`	11/25
`clocale`	4/25
`cmath`	1/19
`compare`	5/14
`complex`	11/25
`concepts`	2/25
`condition_variable`	13/25
`csetjmp`	3/9
`csignal`	4/25
`cstddef`	13/21
`cstdint`	3/5
`cstdio`	4/25
`cstdlib`	3/9
`cstring`	2/5
`ctime`	4/25
`cwchar`	4/25
`deque`	17/25
`exception`	16/21
`filesystem`	2/25
`forward_list`	6/25
`fstream`	8/25
`functional`	10/25
`initializer_list`	0/0
`iomanip`	13/25
`ios`	11/25
`iostream`	0/2
`istream`	10/25
`iterator`	4/25
`limits`	24/25
`list`	4/25
`locale`	6/25
`map`	7/25
`memory`	8/25
`mutex`	13/25
`new`	6/25
`numeric`	3/25
`optional`	8/25
`ostream`	18/25
`random`	3/25
`ranges`	0/25
`ratio`	13/13
`regex`	1/25
`set`	0/25
`sstream`	5/25
`stack`	9/25
`stdexcept`	9/9
`streambuf`	18/25
`string`	1/25
`string_view`	9/25
`system_error`	20/25
`thread`	5/25
`tuple`	7/25
`type_traits`	14/25
`typeinfo`	2/5
`unordered_map`	10/25
`unordered_set`	7/25
`utility`	6/25
`valarray`	0/25
`vector`	18/25
`version`	0/25

Reproduce this on your machine: LLVM_ROOT=$PWD/llvm-project cp sanitize_base_cache.json .compliance_cache.sanitize.json && tools/compliance.py --sanitize --recheck

github-actions · 2026-07-31T07:37:36Z

Compliance diff

No changes detected.

72 header(s) unchanged

header	passes/sampled
`algorithm`	9/40
`any`	9/18
`array`	27/40
`atomic`	16/40
`bit`	2/15
`bitset`	9/40
`cassert`	3/9
`cctype`	2/5
`cerrno`	5/29
`cfloat`	5/29
`chrono`	1/40
`ciso646`	5/29
`climits`	15/40
`clocale`	5/29
`cmath`	1/19
`compare`	5/14
`complex`	17/40
`concepts`	2/35
`condition_variable`	13/26
`csetjmp`	3/9
`csignal`	5/29
`cstddef`	13/21
`cstdint`	3/5
`cstdio`	5/29
`cstdlib`	3/9
`cstring`	2/5
`ctime`	5/29
`cwchar`	5/29
`deque`	29/40
`exception`	16/21
`filesystem`	3/40
`forward_list`	9/40
`fstream`	14/40
`functional`	17/40
`initializer_list`	0/0
`iomanip`	22/40
`ios`	13/40
`iostream`	0/2
`istream`	23/40
`iterator`	5/40
`limits`	36/37
`list`	6/40
`locale`	9/40
`map`	13/40
`memory`	15/40
`mutex`	15/40
`new`	19/40
`numeric`	4/40
`optional`	11/40
`ostream`	31/40
`random`	4/40
`ranges`	0/40
`ratio`	13/13
`regex`	3/40
`set`	1/40
`sstream`	7/40
`stack`	16/36
`stdexcept`	9/9
`streambuf`	30/37
`string`	2/40
`string_view`	15/40
`system_error`	30/40
`thread`	6/40
`tuple`	10/40
`type_traits`	21/40
`typeinfo`	2/5
`unordered_map`	15/40
`unordered_set`	12/40
`utility`	8/40
`valarray`	1/40
`vector`	29/40
`version`	0/40

Reproduce this on your machine: LLVM_ROOT=$PWD/llvm-project cp base_cache.json .compliance_cache.json && tools/compliance.py --recheck

github-actions · 2026-07-31T07:37:38Z

catch2 build-time diff (compile / run tests)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 3 per configuration.

catch2 build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 0.9%.

No significant changes (🟡 2 within noise).

🟡 2 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	14578.5ms	14502.1ms	🟡 -0.5% [-0.8, +0.5]	3.6x
`run tests`	3662.7ms	3665.0ms	🟡 +0.1% [-3.9, +2.9]	0.9x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py catch2 --build-type debug --reps 3

github-actions · 2026-07-31T07:39:22Z

cppcheck build-time diff (compile)

Compiler: c++ (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0.

Repetitions: 2 per configuration.

cppcheck build time with psychicstd, main vs this PR (same runner). 🟢 faster · 🔴 slower · 🟡 within noise. A change is colored only when its bootstrap 95% CI excludes 0 and it clears ±5% / 3ms. vs system is this PR's speedup over system libstdc++, for context -- a regression is less alarming if psychicstd is still far ahead. Median system-time drift (noise proxy): 0.5%.

No significant changes (🟡 1 within noise).

🟡 1 benchmark(s) within noise

benchmark	main	PR	Δ (95% CI)	vs system
`compile`	46456.0ms	46518.5ms	🟡 +0.1% [-0.2, +0.4]	2.0x

Reproduce this on your machine: scripts/compare_realworld_to_ref.py cppcheck --build-type debug --reps 2

fix negative hh_mm_ss components

5c73188

Return non-negative hour, minute, and second components for negative durations. Use an overflow-safe magnitude calculation and cover the behavior with a focused chrono regression test.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix negative hh_mm_ss components - #118

Fix negative hh_mm_ss components#118
pauldreik wants to merge 1 commit into
mainfrom
fix-chrono-hh-mm-ss-negative

pauldreik commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pauldreik commented Jul 31, 2026

Summary

Tests

Uh oh!

github-actions Bot commented Jul 31, 2026

Compile-time performance diff

Uh oh!

github-actions Bot commented Jul 31, 2026

rdfind build-time diff (configure / compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

flatbuffers build-time diff (configure / compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

eigen build-time diff (compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

simdutf build-time diff (compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

fmt build-time diff (compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

Sanitizer diff (ASan/UBSan)

Uh oh!

github-actions Bot commented Jul 31, 2026

Compliance diff

Uh oh!

github-actions Bot commented Jul 31, 2026

catch2 build-time diff (compile / run tests)

Uh oh!

github-actions Bot commented Jul 31, 2026

cppcheck build-time diff (compile)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant