Aj/dev fix some tests and add kwargs to sbml2odesystem function #11
Open
anandijain wants to merge 5 commits intomainfrom
Open
Aj/dev fix some tests and add kwargs to sbml2odesystem function #11anandijain wants to merge 5 commits intomainfrom
anandijain wants to merge 5 commits intomainfrom
Conversation
Owner
|
Thanks for making these changes, here are my comments:
One thing though: In case you forgot to merge into develop and directly merged into main, develop will be left behind. To make sure develop is never behind main, please immediately merge main into develop. We don’t wont anybody to create their own feature branch from an outdated develop. |
Collaborator
Author
|
That's a good point, there is probably a better way to avoid namespace stuff. sbml2modelingtoolkit.jl: Test Failed at /home/runner/work/SbmlInterface.jl/SbmlInterface.jl/test/sbml2modelingtoolkit.jl:31
Expression: repr(ModelingToolkit.get_states(odesys)) == "Term{Real}[A(t), B(t)]"
Evaluated: "Term{Real, Nothing}[A(t), B(t)]" == "Term{Real}[A(t), B(t)]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now we can
Also the
sorton the tests is weird, but I don't think that the prob.p is deterministic. We can easily revert back once that's figured out, in the meantime better to test than not at all.