Security: FFmpeg argument injection via unescaped file names in command string builder#382
Open
Nam0101 wants to merge 1 commit intopaulpacifico:masterfrom
Conversation
… names in command string builder `setAudioFiles()` appends input file paths directly into a command string: `audioFiles += " -i " + '"' + list.getElementAt(i2) + '"' + " ";`. A crafted filename containing quotes or argument separators can break out of the intended argument and inject extra ffmpeg flags (e.g., overwrite outputs, alter mappings, read unintended files), if this string is later executed as a raw command. Affected files: AudioSettings.java Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
While going through the codebase, I noticed a minor opportunity for improvement regarding
src/settings/AudioSettings.java.Context:
setAudioFiles()appends input file paths directly into a command string:audioFiles += " -i " + '"' + list.getElementAt(i2) + '"' + " ";. A crafted filename containing quotes or argument separators can break out of the intended argument and inject extra ffmpeg flags (e.g., overwrite outputs, alter mappings, read unintended files), if this string is later executed as a raw command.Proposed fix:
Replace string-based command construction with argument lists. Return
List<String>instead ofStringand append each token separately:List<String> audioArgs = new ArrayList<>();audioArgs.add("-i");audioArgs.add(list.getElementAt(i2));If refactor is not immediately possible, at minimum escape embedded quotes in file names before concatenation:
path.replace("\\", "\\\\").replace("\"", "\\\"").Files touched:
src/settings/AudioSettings.java(modified)(Note: Tested the changes locally to ensure everything works as expected. Let me know if you need any adjustments, happy to help!)
—
NamNV
📍 Hanoi, Vietnam
📧 nam.nv205106@gmail.com