Skip to content

Consistency overhaul#34

Open
Y-Less wants to merge 106 commits intomasterfrom
consistency-overhaul
Open

Consistency overhaul#34
Y-Less wants to merge 106 commits intomasterfrom
consistency-overhaul

Conversation

@Y-Less
Copy link
Copy Markdown
Member

@Y-Less Y-Less commented Apr 27, 2021

Mostly making parameter names all camelCase consistently.

Y-Less and others added 19 commits April 27, 2021 22:15
@Y-Less
Consistency improvements:
d1ae325 
* No `_` in parameter names.
* ` = ` not `=` in defaults.
* `sizeof (param)`.
* Removed excess blank lines.
* No Hungarian `f` on floats.
@Y-Less
Revert callback name changes because the compiler is picky about them.
c151017
@Y-Less
More camelCase parameter names.
8bad002
@Y-Less
id -> ID
78ef1ca
@Y-Less
Revert forwards again.
35e40a9
@Y-Less
ID is bad...
c37b66d
@Y-Less
More tweaks:
e3584e1 
* Change `<p/>` to `<br />`.
* More `bool:` tags.
* Refine more parameter names.
@Y-Less
Idiomatic DB function naming.
6ec7e5f
@Y-Less
Name tweaks.
a41db32
@Y-Less
Fix clobbered names.
04ca6ac
@Y-Less
Another tag and name clobber.
2fa5a19
@Y-Less
More tags.
c5b0181
@Y-Less
More enums.
5e45fae
Lost a load of commits due to repo corruption:
a14dace 
* `0xFF...`
* Long names.
* Spacing.
* `#pragma unused SAMP_INCLUDES_VERSION`
* Control tag generation with `NO_TAGS`, `WEAK_TAGS`, and `STRONG_TAGS`.
* `WEAK_TAGS`.
* `__MORE` and `__LESS`.
* Proper constants.
* Normal looking tags.
More correct tag syntax.
fc55463
Callback tags.
1c03741
Document progressive tag enhancement.
3704e48
List of all updated callbacks.
cf78bdb
@Y-Less
KEY:.
1d46eb2
@ADRFranklin ADRFranklin mentioned this pull request Nov 23, 2021
Closed
Y_Less added 30 commits March 6, 2022 12:20
Move some defines to more appropriate files:
b0f9fe7 
*a_samp* and *a_players* share standard `playerid` callbacks.  *a_samp* has the basic ones, *a_players* has the ones that respond to functions within it, and those that are for actions between two players.  a_vehicles and a_objects have fairly obvious sets of callbacks.
Change the include order to resolve some new inter-dependencies.
5b3d3a8
And match the checks.
72f3957
Try fix old a_http includes even more.
e55f57a
Add pawndoc="true".
3d89fb0
Remove #define HTTP.
61501d2
Move some comments that seemed to cause an issue.
5ec4cb3
Remove empty pawndoc blocks.
eff8bfd
RACECP_TYPE:
bfb8b6f
Rename (simplify) the checkpoint tag.
045fd54
Some more bool: return tags.
aafb808
Actor bool: returns.
2b6b093
a_vehicle tags.
819876e
Another tag.
570867e
Make GetServerVar... functions aliases for GetConsoleVar....
92f733a
__OPEN_MP_VERSION
2f9dbd3
More bool: return tags.
98d7160
More tags
bcd211b
Unfortunately callbacks can't have their parameter names changed, so …
f058247 
…we are stuck with `color` in `OnClientMessage`.
Remove accidental comments from warnings.
e10ff99
Switch strong/weak tag prefixes to T_/t_ - they're less widely us…
0bf3fc8 
…ed as a prefix.
Move something.
f2d13fd
OnPlayerRequestDownload tag.
7b10fd3
Merge remote-tracking branch 'remotes/origin/master' into consistency…
ae862df 
…-overhaul

# Conflicts:
#	a_players.inc
#	a_samp.inc
Back-port weapon slots.
ceefd22
Use weapon slots.
81ba713
More documentation.
cf49dbe
Typo
ae3989f
PLAYER_VARTYPE_
c2c58d0
Prefer <p/>
8b76202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Southclaws Southclaws Southclaws approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Y-Less @Southclaws