Remove SSL certificate handling from CurlClient#47
Merged
Conversation
This commit removes the handling of SSL certificate errors in the CurlClient class. The specific checks for SSL-related errors (CURLE_SSL_CACERT, CURLE_SSL_PEER_CERTIFICATE, CURLE_SSL_CACERT_BADFILE) and the associated logic for setting the CA bundle have been eliminated. This simplifies the error handling process and removes the dependency on a specific CA bundle file.
nonz250
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #31
This pull request simplifies the
CurlClientimplementation by removing code related to handling SSL certificate errors and the associated CA bundle. These changes streamline the error-handling logic and remove unused functionality.Simplification of SSL error handling:
lib/HttpClient/CurlClient.php: Removed the logic that handled specific SSL certificate errors (CURLE_SSL_CACERT,CURLE_SSL_PEER_CERTIFICATE, andCURLE_SSL_CACERT_BADFILE). This includes removing the addition of custom headers and the use of a CA bundle for retrying requests.Removal of unused methods:
lib/HttpClient/CurlClient.php: Deleted thecaBundlemethod, which was used to retrieve the path to the CA bundle file. This method is no longer needed after the removal of the SSL error-handling logic.