Merged
Conversation
There was a problem hiding this comment.
PR Overview
This pull request adds a new dependency to the gemspec file by including the 'base64' library.
- Added 'base64' dependency to payjp.gemspec
- Minor update to the gemspec to address issue #38
Reviewed Changes
| File | Description |
|---|---|
| payjp.gemspec | Adds the 'base64' dependency to gemspec |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
payjp.gemspec:16
- The 'base64' library is part of Ruby's standard library, so adding it as an external dependency might be unnecessary unless there's a specific reason. Consider removing the dependency declaration if it's not required.
s.add_dependency('base64')
natsuki-yamanaka
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a minor change to the
payjp.gemspecfile, which adds a new dependency to the project.base64as a new dependency in thepayjp.gemspecfile.fix #38