refactor: replace string initialization with String.new for clarity#41
Merged
refactor: replace string initialization with String.new for clarity#41
Conversation
There was a problem hiding this comment.
PR Overview
This PR refactors the initialization of the temporary variable in the url_encode method for clarity and potential performance benefits.
- Replaces the empty string initialization with String.new in the url_encode method.
- Addresses issue #39.
Reviewed Changes
| File | Description |
|---|---|
| lib/payjp/util.rb | Changed the tmp variable initialization from an empty string to String.new for clarity. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
natsuki-yamanaka
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
lib/payjp/util.rbfile to improve theurl_encodemethod. The change replaces the initialization of a temporary string variable from an empty string to a newStringobject for better clarity and potential performance benefits.lib/payjp/util.rb: Modified theurl_encodemethod to initialize thetmpvariable usingString.newinstead of an empty string.fix #39