This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Added service to be used in frontend controller - #3
Open
sprain wants to merge 4 commits into
Open
Conversation
|
ping @mikemeier |
|
@sprain a functional test for this controller would be fine http://symfony.com/doc/current/book/testing.html |
Author
|
@dominikzogg That's right. It didn't have much tests before, that's why it didn't bother yet. But I'll have a look at it. So you like the basic idea and execution? |
|
@sprain well my best example i made until now is this https://github.com/saxulum/saxulum-controller-provider/blob/master/tests/Saxulum/SaxulumControllerProvider/Provider/SaxulumControllerProviderTest.php its made for silex in symfony its nearly the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a service which can easily be used in a frontend controller to initiate a payment. See readme for an example.
What do you think?