Conversation
paytrail-max
force-pushed
the
network-token
branch
3 times, most recently
from
4c8bebb to
9e3f675
Compare
paytrail-max
force-pushed
the
network-token
branch
from
9e3f675 to
3a77e5f
Compare
Contributor
Author
|
Version bump? |
kotivuori
reviewed
Jun 3, 2025
| $this->setExpireYear($networkToken->expire_year); | ||
| $this->setExpireMonth($networkToken->expire_month); | ||
| $this->setImageUrl($networkToken->image_url); | ||
| $this->setPaymentAccountReference($networkToken->payment_account_reference); |
Collaborator
There was a problem hiding this comment.
This can raise a warning: PHP Warning: Undefined property: stdClass::$payment_account_reference
Contributor
Author
There was a problem hiding this comment.
added ?? null to payment account reference 👍
kotivuori
reviewed
Jun 3, 2025
Comment on lines
+138
to
+142
| if (isset($response->networkToken)) { | ||
| $networkToken = new NetworkToken(); | ||
| $networkToken->loadFromStdClass($response->networkToken); | ||
| $this->setNetworkToken($networkToken); | ||
| } |
Collaborator
There was a problem hiding this comment.
Paytrail response has network_token so updating this to $response->network_token fixes it
Contributor
Author
There was a problem hiding this comment.
network_token is optionally returned from the api so isset ok?
kotivuori
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds new field to the getTokenResponse