solving wrong coordination issue with IOS driver#119
Open
alizelzele wants to merge 1 commit intopazone:masterfrom
Open
solving wrong coordination issue with IOS driver#119alizelzele wants to merge 1 commit intopazone:masterfrom
alizelzele wants to merge 1 commit intopazone:masterfrom
Conversation
When using ios driver, size of screenshot taken is double of size reported by element, which cause crop feature to crop wrong area. this fix will check for size difference and scale coords to match with screenshot size
Author
|
Travis CI for AShot repository is not configured correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using IOS driver, size of screenshot taken is double of size reported by element, which cause crop feature to crop wrong area. this fix will check for size difference and scale coords to match with screenshot size