fix(ci): Windows clippy import + build notey-cli before Linux E2E#1
Merged
Conversation
The #[cfg(windows)] branch of raw_conn() called s.as_handle().as_raw_handle() but only imported AsHandle, so as_raw_handle() (provided by the AsRawHandle trait) was not in scope — a hard E0599 compile error that only surfaced on the Windows CI clippy job (the path is never compiled on Linux/macOS). Mirror the Unix branch and import both traits. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The P1-E2E-003 CLI live-sync suite spawns the standalone `notey` binary from notey-cli/target/debug/, but CI never built that workspace-less crate (the tauri build only covers src-tauri), so the spawn failed with ENOENT. Add a Linux-only build step before the E2E run and extend the Cargo cache to cover notey-cli/target/. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two CI failures on
main(run 27559324505).Root causes
src-tauri/src/ipc/socket_server.rsWindows branch calledas_handle().as_raw_handle()without importing theAsRawHandletrait (E0599). Only surfaces on the Windows runner since the#[cfg(windows)]path never compiles on Linux/macOS. Introduced by1f44a33.P1-E2E-003failure — the CLI live-sync suite spawnsnotey-cli/target/debug/notey, but CI never built that standalone crate (only the tauri app), so the spawn hitENOENT. Added by322e570.Fixes
{AsHandle, AsRawHandle}in the Windows branch (mirrors the Unix{AsFd, AsRawFd}).cargo buildstep fornotey-clibefore the E2E run; extend the Cargo cache to covernotey-cli/target/.Verification
cargo clippy -D warningsclean insrc-tauri(Linux).notey-clibuilds →notey-cli/target/debug/noteypresent.🤖 Generated with Claude Code