fix(e2e): make local CLI live-sync E2E rendezvous work on modern WebKitWebDriver#3
Merged
Merged
Conversation
The CLI live-sync suite pinned a unique per-run NOTEY_SOCKET_PATH so the
test app and CLI rendezvous on an isolated endpoint. That relies on the
env var reaching the tauri-driver-launched app. It holds on CI's older
Ubuntu webkit2gtk-driver, but a modern WebKitWebDriver (webkit2gtk 2.52.4)
resets the launched app's environment — stripping NOTEY_SOCKET_PATH and
forcing XDG_RUNTIME_DIR back to the real session value — and tauri-driver
2.0.6 has no env passthrough. So locally the app binds the default
$XDG_RUNTIME_DIR/notey.sock while the CLI looked at the per-run /tmp path:
`notey add` failed exit-2 ("not running"), leaving the suite 14/16 locally
though green on CI.
Discover the socket the app actually bound instead of dictating it: probe
both the configured path and $XDG_RUNTIME_DIR/notey.sock for liveness, then
point the CLI at whichever the app is serving. Add a pre-flight guard that
cleanly skips (not hijacks) the suite when a real notey instance already
owns the default socket. CI behavior is unchanged (it matches the first
candidate); local now runs 16/16 under xvfb. See DW-95.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Local verification of the epic-6 retro surfaced two tracking errors and one new limitation: - epic-6-retro-item-1 cited HEAD 5be24c7 as the "green" E2E run, but that commit's CI is FAILURE and predates the live-sync suite (added in 322e570). The green run is HEAD 3a76bac (run 27566817463), 16/16 incl. live-sync. - The note labeled CLI live-sync "deferred (DW-91/DW-92)"; those are trash-suite hygiene items and the live-sync suite actually shipped. - DW-95: modern WebKitWebDriver resets the test app's env, preventing per-run IPC socket isolation locally — documented alongside the test-only fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local E2E was only partially fixed: the rendering crash was solved, but the CLI live-sync suite (P1-E2E-003) failed locally (
notey add→ exit-2 "Notey is not running"), leaving the suite 14/16 locally while green on CI.Root cause (verified, not guessed)
NOTEY_SOCKET_PATHand relies on it reaching thetauri-driver-launched app.webkit2gtk 2.52.4) resets the launched app's environment — stripsNOTEY_SOCKET_PATHand forcesXDG_RUNTIME_DIRback to the real session value — andtauri-driver 2.0.6has no env passthrough (forwards only{binary, args}).$XDG_RUNTIME_DIR/notey.sockwhile the CLI looked at the/tmpper-run path → mismatch./run/user/1000/notey.sockexisted and no/tmp/notey-e2e-*.sockwas ever created.webkit2gtk-driverpasses env through, which is why it only bit locally.Fix (test-only —
e2e/run.mjs)Stop dictating the socket; discover the one the app actually bound — probe the configured path and
$XDG_RUNTIME_DIR/notey.sockfor liveness, then point the CLI there. A pre-flight guard cleanly skips (does not hijack) the suite if a realnoteyalready owns the default socket.NOTEY_SOCKET_PATH).Also in this PR
epic-6-retro-item-1note insprint-status.yaml(it cited a failing commit as "green" and mislabeled live-sync as deferred).Verification
xvfb-run node e2e/run.mjs→ 16 passed, 0 failed (incl. trash-lifecycle + CLI live-sync).🤖 Generated with Claude Code