Skip to content

fix(darwin): mprotect order that caused a hang #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pboyd merged 1 commit into from
Mar 25, 2026
Merged

fix(darwin): mprotect order that caused a hang #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/static/duplicate_darwin_arm64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,16 @@ func patchRodataCodePtrs(offset uintptr, moddata *moduledata) error {
}
}

_, err = mach.VmRemap(mapStart, uintptr(tmpPtr), size)
err = unix.Mprotect(tmpSlice, unix.PROT_READ|unix.PROT_EXEC)
if err != nil {
unix.MunmapPtr(tmpPtr, size)
return fmt.Errorf("vm_remap rodata (%d bytes at %#x): %w", size, mapStart, err)
return fmt.Errorf("mprotect temp to r-x: %w", err)
}

if err := unix.Mprotect(unsafe.Slice((*byte)(unsafe.Pointer(mapStart)), int(size)), unix.PROT_READ); err != nil {
return fmt.Errorf("mprotect rodata to r: %w", err)
_, err = mach.VmRemap(mapStart, uintptr(tmpPtr), size)
if err != nil {
unix.MunmapPtr(tmpPtr, size)
return fmt.Errorf("vm_remap rodata (%d bytes at %#x): %w", size, mapStart, err)
}

unix.MunmapPtr(tmpPtr, size)
Expand Down
Loading