homework complete#14
Open
Alexlied wants to merge 1 commit into
Open
Conversation
bwreid
reviewed
Jul 20, 2019
| } | ||
| else { | ||
| const fruitIndex = fruits.indexOf(fruit); | ||
| fruits[fruitIndex] = { id: id, ...req.body } |
Contributor
There was a problem hiding this comment.
You shouldn't need to construct a new object inside a GET ONE route. Right now, this route is only returning the ID because of it.
|
|
||
| res.status(200).json({ | ||
| message: 'Handling POST requests to /fruits' | ||
| }) |
Contributor
There was a problem hiding this comment.
Having two res.json()s will cause the following error to surface:
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
I think this is also causing some problems later on to make the GET ALL /fruits request.
|
|
||
| const updatedFruits = fruits.filter(fruits => fruits.id !== id) | ||
|
|
||
| console.log(updatedFruits) |
Contributor
There was a problem hiding this comment.
Remove console.log() statements before committing, please!
|
|
||
| res.status(200).json({ | ||
| message: 'Deleted message' | ||
| }) |
Contributor
There was a problem hiding this comment.
Same thing here, you should only be responding once per route (unless you have some kind of if/else)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.