This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Rails 3.1.0+ compatibility (and a few other minor improvements)#32
Open
Empact wants to merge 13 commits intopdeffendol:masterfrom
Open
Rails 3.1.0+ compatibility (and a few other minor improvements)#32Empact wants to merge 13 commits intopdeffendol:masterfrom
Empact wants to merge 13 commits intopdeffendol:masterfrom
Conversation
…odule, with most methods relying directly on super rather than aliasing. Have some failures when moving the rest - not sure why.
…n until after active record has been loaded.
…oncern module, with most methods relying directly on super rather than aliasing. Have some failures when moving the rest - not sure why." Was having trouble with module methods not overriding the base methods after inclusion - not sure what the cause for that was. This reverts commit 9a2a657. Conflicts: lib/spatial_adapter/postgresql.rb
…, as is done in the rails 3.1 codebase
… detect their success, and properly remove the created indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I made some improvements to spatial adapter to get it working under Rails 3.1.0 for my own use, and posted about fork here: #26
Several people have confirmed that it works for them and one has suggested a pull request, so here it is.
One issue, which I noted in my original comment to that thread: