Open
Conversation
Owner
|
Sorry @tbruyelle I've had very little spare time to work on stuff recently, I'll try and get a review in this week, at a glance it looks fine though. |
Owner
|
I should also note that I don't really consider this production code, it was just meant to be a proof of concept. |
Author
Yes I get that, I'm using it in a side branch of my project. But from what I read in hexops/vecty#77, vecty will include a built-in router, so I'm just trying to make things progress a little bit, if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @pdf,
I started to play with your router, because I need one for my project. This is first PR to handle the last changes of the Vecty API.
I'm currently working on history/pushState support, maybe an other PR will follow.
Thanks for your work on this router, sounds great from what I tested.