Conversation
* feat: abstract squid route fetching Stop using the skd and use the squid API directly, this give us more control and access to all the data that returns squid (for example, we now have access to the fees and don't have to recalculate them ourselves) * refactor: use parseunits Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: remove console.dir * feat: handle very large numbers with careful scaling * refactor: use const for squid api url * feat: add cross-chain action card Use coral through squid to get the cross-chain route for the different flows. This enables xchain withdraw for peanut wallet * refactor: use decimals from token price instead of hardcoded * style: Apply prettier formatting * feat: show min received for cross-chain payments * chore: clean unused variables * fix: tests ach_pull to ach * fix: pr comments * fix: withdrawData and pulsate animation * fix: cursor placement in token amount input * fix: delete unused code * fix: add camera perm modal * fix: enable mexico bank offramp * refactor: better comments for direct usd payments * feat: add qr scanning for xchain * fix: remove malicious code * fix: handle mxn in offramp destination details (#945) * fix: show share receipt option in direct send status view (#946) * [TASK-12678] fix: coral withdraw fixes (#949) * fix: coral withdraw fixes - Stop refreshing the page after successful payment - Better error message for unsupported token pairs * chore: add squid env vars * refactor: better copy for non rfq routes from peanut wallet Also send warning to sentry * fix: show amount in USD for withdrawals to other tokens to other tokens * fix: lock orientation to portrait mode (#947) * fix: lock orienatation to protrait mode * style(fix): add new line * style: format * fix: if condition * fix: update payment form for crosschain add money (#954) * [TASK-12682] fix: show token selector for guest flow (#955) * fix: show token selector for guest flow * docs: add comment to explain url request flow * implemented Context instead of sessionStorage in onrampData to avoid discrepancies with the Offramp logic (#953) * refactor: fetch external wallet balances from mobula (#956) (#958) * [TASK-12645] copy button for individual fields (#960) * copy button for individual fields * changed getOnrampCurrencyConfig (deprecated)to getCurrencyConfig + user now copies raw IBAN value * fix: gas estimation for external wallets (#961) We were re-rendering unnecesarily the prepare transaction, also now we catch error if any * [TASK-12603] reset send flow state when navigating to/from payment link creation (#964) * reset send flow state when navigating to/from payment link creation * linting (formatting) * [TASK-12312] ENS/eth address network error being displayed on the frontend (#963) * ENS/eth address network error being displayed on the frontend * linting * fix: centre align views on mobile (#950) * [TASK-12542] added formatIban function for correct display (#952) * added formatIban function for correct display * coderabbit suggestion Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * updated formatting * added iban formatting in all pages --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * [TASK-12672] feat: show sponsored by peanut message (#959) * feat: show sponsored by peanut message This message is shown when we are making a transaction from the peanut wallet. If the amount is more than one cent we also show the fee that the user is saving by using peanut. * fix(fees): show correct ammounts for externalwallet * refactor: rename estimatedGasCostUsd to estimatedGasCostUsdUsd * fix: correct approval owner and base rpc (#965) Two things here: 1. We were using the peanut address for approval checking on deposits, this didn't affect because if the approval call failed we just continued with the deposit 2: The base rpc url was the sepolia one, not the mainnet. Big oversight there * feat: add alachemy as fallback rpc url (#948) * feat: add alachemy as fallback rpc url * fix: remove commented line * fix: address pr review comments * [TASK-12866] fix: small fixes around crosschain ui (#966) * fix: small fixes around crosschain ui * fix: avoid negative expiry time * removed white spaces before processing to BIC (#951) * feat: resuable slider component (#968) * fix: update desktop navigation with add/withdraw paths (#969) * [TASK-11884] request via link with comment and attachment is creating 2 txs in the history (#943) * PATCH implemented in frontend * comment input state updating correctly (onBlur) * freezing amount after updating comments/files input * debounce attachment options and update requests on file change (avoiding race conditions when attaching files!) * style: Apply prettier formatting * removed malicious code Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * PATCH method using withFormData * better onBlur logic * bug fixes * blur logic fixed * nit pick comments * code rabbit suggestion * replaced useEffect setting state with derived state and debouncing * disabling amount input after request creation * linting --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * fix: support page staging (#972) * fix: update desktop navigation with add/withdraw paths * fix: support page * fix: ui comments (#973) * Support and beta changes to staging (#978) * refactor: fetch external wallet balances from mobula (#956) * fix: update desktop navigation (#970) * fix: support page prod (#971) * fix: update desktop navigation * fix: support page * [TASK-12746] feat: beta changes (#975) * feat: beta changes - Banner that redirects to support page - Funds warning modal * refactor(banner): remove from landing and add hand thumbs up --------- Co-authored-by: Kushagra Sarathe <76868364+kushagrasarathe@users.noreply.github.com> * [TASK-12312] Bugfix/ens error withdrawing (#976) * ENS/eth address network error being displayed on the frontend * linting * fixed andre QA observations * deleting console.log * formatting * logic fixed * fixed testst --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * fix: coral small issues (#979) * chore: enable usdt in mainnet (#980) * fix: slider tap bug logic (#983) * fix: slider tap bug logic * fix: tap bug on slider * fix: some issues and comments (#984) * [TASK-12771] Feat/new landing page (#974) * removed legacy button and changed try now button colors * try now button color and hero description * YourMoney component * NoFees component first part * stars done * scribble in zero fees * no hidden fees section done * securityBuiltIn done * sendInSeconds progress * sendInSeconds done * updated try now button to be a link * business integration initiation * businessIntegrate done * order and marquee reusability * order fixed * background animations in Landing Page compoejnnts * changed image for text in hero section * figma details * landing page responsiveness improvements * landing page responsiveness done * coderabbit suggestion * business integration button * fixed iphone screenshots * CTA button animation * added debugging for CTA button animation * changed animation since react gave errors * arrows in hero section * NoFees new Zero * no fees responsiveness fixed * sendInSeconds details done * coderabbit suggestions * formatting * hand-token wasnt pushed? forgot to stage or sum? anyways fixed * build issues fixed * coderabbit optimization * code formatting * arrows and ZERO thickness * shade in try now button * progress in button animation * undoing button changes * small detail fixes * added asset * changed peanut business to svg * integrate peanut component done * added pay-zero-fees.svg * added new illustrations * uout money anywhere svg * securitybuiltin component SVGs * adding YourMoney new SVGs * your money anywhere component * instantly send & receive svg * arrows fixed * button and arrows done * desktop sendinseconds button done * removed arrows disappearing effect * MOBILE: hero button done * added mobile svg * yourMoney responsive component done * added mobile-zero-fees.svg * added no-hidden-fees.svg * noFees mobile svg * noFees desktop + mobile improvements * noFees done * mobile security built in SVG * securityprivacy mobile done * mobile-send-in-seconds.svg * sendInSeconds mobile done * business integrate mobile * business integrate button and final details * removed footer * formatting * removed pino-pretty * fixed button instead of sticky/floating --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * [TASK-13136] feat: allow uppercase in url (#986) * feat: allow uppercase in url * fix: allow uppercase in recipient * fix: inform create request type when creating from UI (#987) * fix: balance warning modal (#988) - Slider instead of button - Expiry for local storage instead of session storage - Warning icon color * chore: remove unused file (#990) * feat: send links guest flow ( exchange/crypto) (#982) * feat: update add/withdraw flow to use new slider component * feat: guest receive to exchange/crypto flows * fix: coderabbit comments * fix: slider usage * Chore/prod to staging (#994) * refactor: fetch external wallet balances from mobula (#956) * fix: update desktop navigation (#970) * fix: support page prod (#971) * fix: update desktop navigation * fix: support page * [TASK-12746] feat: beta changes (#975) * feat: beta changes - Banner that redirects to support page - Funds warning modal * refactor(banner): remove from landing and add hand thumbs up * [TASK-13082] Sprint 100 prod release (#992) * feat: abstract squid route fetching Stop using the skd and use the squid API directly, this give us more control and access to all the data that returns squid (for example, we now have access to the fees and don't have to recalculate them ourselves) * refactor: use parseunits Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * refactor: remove console.dir * feat: handle very large numbers with careful scaling * refactor: use const for squid api url * feat: add cross-chain action card Use coral through squid to get the cross-chain route for the different flows. This enables xchain withdraw for peanut wallet * refactor: use decimals from token price instead of hardcoded * style: Apply prettier formatting * feat: show min received for cross-chain payments * chore: clean unused variables * fix: tests ach_pull to ach * fix: pr comments * fix: withdrawData and pulsate animation * fix: cursor placement in token amount input * fix: delete unused code * fix: add camera perm modal * fix: enable mexico bank offramp * refactor: better comments for direct usd payments * feat: add qr scanning for xchain * fix: remove malicious code * fix: handle mxn in offramp destination details (#945) * fix: show share receipt option in direct send status view (#946) * [TASK-12678] fix: coral withdraw fixes (#949) * fix: coral withdraw fixes - Stop refreshing the page after successful payment - Better error message for unsupported token pairs * chore: add squid env vars * refactor: better copy for non rfq routes from peanut wallet Also send warning to sentry * fix: show amount in USD for withdrawals to other tokens to other tokens * fix: lock orientation to portrait mode (#947) * fix: lock orienatation to protrait mode * style(fix): add new line * style: format * fix: if condition * fix: update payment form for crosschain add money (#954) * [TASK-12682] fix: show token selector for guest flow (#955) * fix: show token selector for guest flow * docs: add comment to explain url request flow * implemented Context instead of sessionStorage in onrampData to avoid discrepancies with the Offramp logic (#953) * refactor: fetch external wallet balances from mobula (#956) (#958) * [TASK-12645] copy button for individual fields (#960) * copy button for individual fields * changed getOnrampCurrencyConfig (deprecated)to getCurrencyConfig + user now copies raw IBAN value * fix: gas estimation for external wallets (#961) We were re-rendering unnecesarily the prepare transaction, also now we catch error if any * [TASK-12603] reset send flow state when navigating to/from payment link creation (#964) * reset send flow state when navigating to/from payment link creation * linting (formatting) * [TASK-12312] ENS/eth address network error being displayed on the frontend (#963) * ENS/eth address network error being displayed on the frontend * linting * fix: centre align views on mobile (#950) * [TASK-12542] added formatIban function for correct display (#952) * added formatIban function for correct display * coderabbit suggestion Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * updated formatting * added iban formatting in all pages --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * [TASK-12672] feat: show sponsored by peanut message (#959) * feat: show sponsored by peanut message This message is shown when we are making a transaction from the peanut wallet. If the amount is more than one cent we also show the fee that the user is saving by using peanut. * fix(fees): show correct ammounts for externalwallet * refactor: rename estimatedGasCostUsd to estimatedGasCostUsdUsd * fix: correct approval owner and base rpc (#965) Two things here: 1. We were using the peanut address for approval checking on deposits, this didn't affect because if the approval call failed we just continued with the deposit 2: The base rpc url was the sepolia one, not the mainnet. Big oversight there * feat: add alachemy as fallback rpc url (#948) * feat: add alachemy as fallback rpc url * fix: remove commented line * fix: address pr review comments * [TASK-12866] fix: small fixes around crosschain ui (#966) * fix: small fixes around crosschain ui * fix: avoid negative expiry time * removed white spaces before processing to BIC (#951) * feat: resuable slider component (#968) * fix: update desktop navigation with add/withdraw paths (#969) * [TASK-11884] request via link with comment and attachment is creating 2 txs in the history (#943) * PATCH implemented in frontend * comment input state updating correctly (onBlur) * freezing amount after updating comments/files input * debounce attachment options and update requests on file change (avoiding race conditions when attaching files!) * style: Apply prettier formatting * removed malicious code Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * PATCH method using withFormData * better onBlur logic * bug fixes * blur logic fixed * nit pick comments * code rabbit suggestion * replaced useEffect setting state with derived state and debouncing * disabling amount input after request creation * linting --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * fix: support page staging (#972) * fix: update desktop navigation with add/withdraw paths * fix: support page * fix: ui comments (#973) * Support and beta changes to staging (#978) * refactor: fetch external wallet balances from mobula (#956) * fix: update desktop navigation (#970) * fix: support page prod (#971) * fix: update desktop navigation * fix: support page * [TASK-12746] feat: beta changes (#975) * feat: beta changes - Banner that redirects to support page - Funds warning modal * refactor(banner): remove from landing and add hand thumbs up --------- Co-authored-by: Kushagra Sarathe <76868364+kushagrasarathe@users.noreply.github.com> * [TASK-12312] Bugfix/ens error withdrawing (#976) * ENS/eth address network error being displayed on the frontend * linting * fixed andre QA observations * deleting console.log * formatting * logic fixed * fixed testst --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * fix: coral small issues (#979) * chore: enable usdt in mainnet (#980) * fix: slider tap bug logic (#983) * fix: slider tap bug logic * fix: tap bug on slider * fix: some issues and comments (#984) * [TASK-12771] Feat/new landing page (#974) * removed legacy button and changed try now button colors * try now button color and hero description * YourMoney component * NoFees component first part * stars done * scribble in zero fees * no hidden fees section done * securityBuiltIn done * sendInSeconds progress * sendInSeconds done * updated try now button to be a link * business integration initiation * businessIntegrate done * order and marquee reusability * order fixed * background animations in Landing Page compoejnnts * changed image for text in hero section * figma details * landing page responsiveness improvements * landing page responsiveness done * coderabbit suggestion * business integration button * fixed iphone screenshots * CTA button animation * added debugging for CTA button animation * changed animation since react gave errors * arrows in hero section * NoFees new Zero * no fees responsiveness fixed * sendInSeconds details done * coderabbit suggestions * formatting * hand-token wasnt pushed? forgot to stage or sum? anyways fixed * build issues fixed * coderabbit optimization * code formatting * arrows and ZERO thickness * shade in try now button * progress in button animation * undoing button changes * small detail fixes * added asset * changed peanut business to svg * integrate peanut component done * added pay-zero-fees.svg * added new illustrations * uout money anywhere svg * securitybuiltin component SVGs * adding YourMoney new SVGs * your money anywhere component * instantly send & receive svg * arrows fixed * button and arrows done * desktop sendinseconds button done * removed arrows disappearing effect * MOBILE: hero button done * added mobile svg * yourMoney responsive component done * added mobile-zero-fees.svg * added no-hidden-fees.svg * noFees mobile svg * noFees desktop + mobile improvements * noFees done * mobile security built in SVG * securityprivacy mobile done * mobile-send-in-seconds.svg * sendInSeconds mobile done * business integrate mobile * business integrate button and final details * removed footer * formatting * removed pino-pretty * fixed button instead of sticky/floating --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * [TASK-13136] feat: allow uppercase in url (#986) * feat: allow uppercase in url * fix: allow uppercase in recipient * fix: inform create request type when creating from UI (#987) * fix: balance warning modal (#988) - Slider instead of button - Expiry for local storage instead of session storage - Warning icon color * chore: remove unused file (#990) * chore: re-add removed code for gas estimation --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: kushagrasarathe <76868364+kushagrasarathe@users.noreply.github.com> Co-authored-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> Co-authored-by: Kushagra Sarathe <76868364+kushagrasarathe@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> * refactor(payments): add payerAddress to payment creation (#1002) * feat: claim a send link to bank flow (#995) * feat: update add/withdraw flow to use new slider component * feat: guest receive to exchange/crypto flows * fix: coderabbit comments * fix: slider usage * feat: new server actions for guest flow * feat: update card and success view component for bank claims * feat: claim to bank flow components * fix: coderbbit comments * fix: import * feat: handle bank link claims for when sender is non-kyced (#996) * feat: handle bank link claims for when sender is non-kyced * fix: kyc status check for sender * fix: codderabbit comments * fix: update route payloads based on be changes * fix: merge conflict * feat: ui updates to bank flow * fix: rename comp name * fix: wrap fn in callback * feat: min ammount modal for send link claims * [TASK-12649] fix: allow user to change their email address if they have not completed kyc (#999) * fix: allow user to change their email address if they have not completed kyc * fix: account incorrect field * Feat: Landing page changes (#1006) * fix: links v2 send flow qa fixes (#1008) * fix: add reuseOnError key for guest external accounts creation * fix: success view for guest claim to bank account flow * fix: infinite loop of post signup flow using claim link * fix: back btn navigation * fix: show confirm view for xchain claims * fix: links v2 qa bug fixes (#1014) * feat: add slider in withdraw crypto flow * fix: cross chain claiming * fix: claim modal on homepage * fix: coral issue on staging (#1018) * fix: coral issue on staging * fix: squid api url const * Make txn history private (#1017) * chore: update mobula endpoint (#1020) * chore: update mobula endpoint * Update tokens.ts Signed-off-by: Hugo Montenegro <hugo@peanut.to> --------- Signed-off-by: Hugo Montenegro <hugo@peanut.to> Co-authored-by: Hugo Montenegro <hugo@peanut.to> * fix: minor bugs before prod-release (#1025) * fix: add money ui issue for same chain external wallet txn * fix: amount in withdraw to crypto sucess view * fix: reset states on flows (#1026) * fix: add money ui issue for same chain external wallet txn * fix: amount in withdraw to crypto sucess view * fix; reset states * merge: peanut-wallet in peanut-wallet-dev * fix: remove dupe title * merge: peanut-wallet in peanut-wallet-dev (#1032) * merge: peanut-wallet in peanut-wallet-dev * fix: remove dupe title * Fix KYC issues (#1029) * fix: TOS acceptance taking too much time * remove log * Fix: add money button position (#1031) * fix: Wrong flag shown in add monet flow for some countries (#1027) * fix(kernel-client): catch kernel client errors (#1036) * fix: more and more bugssssss (#1030) * fix: guest flow navigation and ofac * fix: withdraw flow navigation * fix: always show usd value in reciept and success views * fix: show $ in txn drawer * fix: mark prop as optional * fix: update text (#1035) * feat: guest claimed link history ui (#1007) * feat: guest claimed link history ui * fix: pr review comments * fix: format transfer id * Fix: Add crypto showing incorrect view on refresh (#1028) * fix: refreshing the page in the last screen when adding money shows the money was successfully added when it wasn’t * fix: payment not working on refresh * fix: charge state bug * feat: add subtext (#1019) * fix: refetch wallet balance (#1040) * chore: remove dead code * fix: refetch wallet balance wen direct req is paid * fix: activity issues (#1034) * fix: campaign icon (#1037) * Fix: Cancel button not showing for send and request link creator (#1039) * Fix: Cancel button not showing for send and request link creator * Add Cancel link warning modal * remove unused import * Fix: loading states * nit: use `currentColor` * Fix : buttons loading state * copy changes for hotfix from prod (#1042) * fix btn position (#1043) * Fix: KYC modal close button not working in withdraw flow (#1044) * fix: KYC modal close btn not working in withdraw flow * remove logs * Fix kyc close navigation flow (#1046) * Fix/withdraw amt issue (#1045) * fix: withdraw amount state issue * fix: amount in PeanutActionDetailsCard * fix: withdraw usd value * fix(semantic-send): fix history for payments (#1048) Treat as a direct send if there is no request id * fix: bic fetching (#1050) * fix: kyc issues (yes, again, and it works this time) (#1052) * fix: kyc iframe closing on verfication done * fix: tos closing issue * typo hotfix --------- Signed-off-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> Signed-off-by: Hugo Montenegro <hugo@peanut.to> Co-authored-by: Juan José Ramírez <artjjrn@gmail.com> Co-authored-by: Juan José Ramírez <70615692+jjramirezn@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: facundobozzi <72771544+FacuBozzi@users.noreply.github.com> Co-authored-by: Mohd Zishan <72738005+Zishan-7@users.noreply.github.com> Co-authored-by: Hugo Montenegro <hugo@peanut.to> Co-authored-by: Hugo Montenegro <h@hugomontenegro.com>
* init status endpoints * feat: status health endpoints * discord notifs * cleanup
* chore: show maintainance banner * chore: remove maintatinence banner * fix: merge conflicts * chore: under maintainanace * chore: under maintainanace banner in layouts --------- Signed-off-by: Kushagra Sarathe <76868364+kushagrasarathe@users.noreply.github.com>
* chore: show maintainance banner * chore: remove maintatinence banner * fix: merge conflicts * chore: under maintainanace * chore: under maintainanace banner in layouts * chore: remove maintainance banner * chore: remove banner --------- Signed-off-by: Kushagra Sarathe <76868364+kushagrasarathe@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis change introduces new health check API endpoints for multiple backend services, refactors and extends the withdraw flow to support USD-based validation and state, and adds a modal-driven UI for canceling send links. It also removes several unused Bruddle UI components, updates transaction details handling for new transaction types, and makes targeted UI and logic improvements across payment, claim, and home components. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 10
🧹 Nitpick comments (9)
src/components/LandingPage/hero.tsx (1)
151-152: Hard-coded copy bypasses localisation pipelineEvery new user-facing string should go through the existing i18n mechanism (e.g.
t('landing.cta.timeHint')) so the landing page remains translatable. Consider replacing the literal text with a translation key and adding the corresponding entry to the locale files.- <p className="font-roboto-flex-bold mt-2 text-xs italic text-n-1 md:text-sm">Takes 10 seconds</p> + <p className="font-roboto-flex-bold mt-2 text-xs italic text-n-1 md:text-sm"> + {t('landing.cta.timeHint', { defaultValue: 'Takes 10 seconds' })} + </p>src/components/Global/Icons/Icon.tsx (1)
53-53: Fix typo in component name.The component name
LinkShashIconappears to have a typo - it should likely beLinkSlashIconto match the conventional naming pattern and the file pathlink-slash.tsx.Apply this diff to fix the naming:
-import { LinkShashIcon } from './link-slash' +import { LinkSlashIcon } from './link-slash'And update the mapping:
- 'link-slash': LinkShashIcon, + 'link-slash': LinkSlashIcon,Note: This would also require updating the component name in
src/components/Global/Icons/link-slash.tsx.Also applies to: 143-143
src/components/Global/Icons/link-slash.tsx (1)
3-3: Fix component name typo.The component name
LinkShashIconcontains a typo - it should beLinkSlashIconto match conventional naming patterns and the file name.Apply this diff:
-export const LinkShashIcon: FC<SVGProps<SVGSVGElement>> = (props) => { +export const LinkSlashIcon: FC<SVGProps<SVGSVGElement>> = (props) => {Note: This change should be coordinated with the import in
src/components/Global/Icons/Icon.tsx.src/app/[...recipient]/client.tsx (1)
58-93: Great refactoring!Extracting the charge fetching logic into
fetchChargeDetailsimproves code organization and reusability. The function properly handles USD amount calculation from either currency data or token price.Consider adding loading state management to provide better UX during charge fetching:
const fetchChargeDetails = async () => { if (!chargeId) return + // Consider setting a loading state here chargesApi .get(chargeId) .then(async (charge) => {src/app/(mobile-ui)/withdraw/page.tsx (1)
69-74: Potential redundant flow resetThe effect resets the withdraw flow whenever
amountFromContextis falsy. This could cause unintended resets if the amount temporarily becomes falsy during updates.Consider adding a more specific condition to avoid unnecessary resets:
useEffect(() => { - if (!amountFromContext) { + if (!amountFromContext && step === 'inputAmount') { resetWithdrawFlow() } -}, [amountFromContext, resetWithdrawFlow]) +}, [amountFromContext, resetWithdrawFlow, step])src/components/Send/link/views/Success.link.send.view.tsx (1)
89-91: Inconsistent prop namingThe prop
setshowCancelLinkModaldoesn't follow camelCase convention.- setshowCancelLinkModal={setshowCancelLinkModal} + setShowCancelLinkModal={setShowCancelLinkModal}Also update the state declaration:
-const [showCancelLinkModal, setshowCancelLinkModal] = useState(false) +const [showCancelLinkModal, setShowCancelLinkModal] = useState(false)src/components/TransactionDetails/TransactionDetailsDrawer.tsx (1)
126-126: Inconsistent prop naming patternSimilar to the previous file,
setshowCancelLinkModaldoesn't follow camelCase convention.-const [showCancelLinkModal, setshowCancelLinkModal] = useState(false) +const [showCancelLinkModal, setShowCancelLinkModal] = useState(false)And update all usages:
- setshowCancelLinkModal={setshowCancelLinkModal} + setShowCancelLinkModal={setShowCancelLinkModal}Also applies to: 883-883
src/app/api/health/mobula/route.ts (1)
31-31: Consider making test parameters configurableThe USDC contract address and blockchain ID are hardcoded. Consider extracting these as constants with documentation explaining why these specific values were chosen for health checks.
Add constants at the top of the file:
// Test parameters - using USDC on Ethereum as a reliable test case const TEST_ASSET_ADDRESS = '0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48' // USDC on Ethereum const TEST_BLOCKCHAIN_ID = 1 // Ethereum mainnet const TEST_WALLET_ADDRESS = '0x9647BB6a598c2675310c512e0566B60a5aEE6261' // Known address with balancesrc/app/api/health/rpc/route.ts (1)
48-54: Improve provider name detection logicThe nested ternary operators reduce readability. Consider extracting this logic into a helper function.
+const getProviderName = (rpcUrl: string, index: number): string => { + if (rpcUrl.includes('infura')) return 'infura' + if (rpcUrl.includes('alchemy')) return 'alchemy' + if (rpcUrl.includes('bnbchain')) return 'binance' + return `provider_${index}` +} + for (let i = 0; i < chainRpcs.length; i++) { const rpcUrl = chainRpcs[i] - const providerName = rpcUrl.includes('infura') - ? 'infura' - : rpcUrl.includes('alchemy') - ? 'alchemy' - : rpcUrl.includes('bnbchain') - ? 'binance' - : `provider_${i}` + const providerName = getProviderName(rpcUrl, i)
|
|
||
| // Test a second endpoint - ENS name lookup (if available) | ||
| const lookupTestStart = Date.now() | ||
| let lookupHealth: any = { status: 'not_tested', message: 'Lookup endpoint not tested' } |
There was a problem hiding this comment.
Replace any type with proper type definition
Using any type reduces type safety. Define a proper type for the lookup health status.
-let lookupHealth: any = { status: 'not_tested', message: 'Lookup endpoint not tested' }
+interface HealthStatus {
+ status: 'healthy' | 'degraded' | 'not_tested'
+ responseTime?: number
+ httpStatus?: number
+ message?: string
+ error?: string
+}
+
+let lookupHealth: HealthStatus = { status: 'not_tested', message: 'Lookup endpoint not tested' }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let lookupHealth: any = { status: 'not_tested', message: 'Lookup endpoint not tested' } | |
| interface HealthStatus { | |
| status: 'healthy' | 'degraded' | 'not_tested' | |
| responseTime?: number | |
| httpStatus?: number | |
| message?: string | |
| error?: string | |
| } | |
| let lookupHealth: HealthStatus = { status: 'not_tested', message: 'Lookup endpoint not tested' } |
🤖 Prompt for AI Agents
In src/app/api/health/justaname/route.ts at line 43, replace the use of the
`any` type for the variable `lookupHealth` with a proper type definition that
accurately reflects the structure of the object, such as an interface or type
alias with `status` and `message` properties as strings. Define this type above
or import it if already defined, then annotate `lookupHealth` with this type to
improve type safety.
| // Test 2: Portfolio endpoint (using a known address with likely balance) | ||
| const portfolioTestStart = Date.now() | ||
| const portfolioResponse = await fetchWithSentry( | ||
| `${MOBULA_API_URL}/api/1/wallet/portfolio?wallet=0x9647BB6a598c2675310c512e0566B60a5aEE6261`, | ||
| { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| authorization: MOBULA_API_KEY, | ||
| }, | ||
| } | ||
| ) | ||
| const portfolioResponseTime = Date.now() - portfolioTestStart | ||
|
|
||
| const portfolioHealthy = portfolioResponse.ok | ||
|
|
||
| // If portfolio API is down, throw error to return HTTP 500 | ||
| if (!portfolioHealthy) { | ||
| throw new Error(`Portfolio API returned ${portfolioResponse.status}`) | ||
| } | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add response validation for portfolio endpoint
The portfolio endpoint response is not validated for data structure, unlike the price endpoint. Consider adding validation to ensure the API returns expected data format.
const portfolioResponseTime = Date.now() - portfolioTestStart
-const portfolioHealthy = portfolioResponse.ok
+if (!portfolioResponse.ok) {
+ throw new Error(`Portfolio API returned ${portfolioResponse.status}`)
+}
-// If portfolio API is down, throw error to return HTTP 500
-if (!portfolioHealthy) {
- throw new Error(`Portfolio API returned ${portfolioResponse.status}`)
+const portfolioData = await portfolioResponse.json()
+// Validate expected structure (adjust based on actual API response)
+if (!portfolioData || typeof portfolioData !== 'object') {
+ throw new Error('Invalid portfolio data structure')
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // Test 2: Portfolio endpoint (using a known address with likely balance) | |
| const portfolioTestStart = Date.now() | |
| const portfolioResponse = await fetchWithSentry( | |
| `${MOBULA_API_URL}/api/1/wallet/portfolio?wallet=0x9647BB6a598c2675310c512e0566B60a5aEE6261`, | |
| { | |
| headers: { | |
| 'Content-Type': 'application/json', | |
| authorization: MOBULA_API_KEY, | |
| }, | |
| } | |
| ) | |
| const portfolioResponseTime = Date.now() - portfolioTestStart | |
| const portfolioHealthy = portfolioResponse.ok | |
| // If portfolio API is down, throw error to return HTTP 500 | |
| if (!portfolioHealthy) { | |
| throw new Error(`Portfolio API returned ${portfolioResponse.status}`) | |
| } | |
| const portfolioResponseTime = Date.now() - portfolioTestStart | |
| if (!portfolioResponse.ok) { | |
| throw new Error(`Portfolio API returned ${portfolioResponse.status}`) | |
| } | |
| const portfolioData = await portfolioResponse.json() | |
| // Validate expected structure (adjust based on actual API response) | |
| if (!portfolioData || typeof portfolioData !== 'object') { | |
| throw new Error('Invalid portfolio data structure') | |
| } |
🤖 Prompt for AI Agents
In src/app/api/health/mobula/route.ts between lines 50 and 69, the portfolio
endpoint response is not validated for its data structure. To fix this, add a
validation step after receiving the portfolioResponse to check that the response
JSON matches the expected format (e.g., required fields and types). If the
validation fails, throw an error to handle unexpected or malformed data, similar
to how the price endpoint response is validated.
| const failedServices = Object.entries(healthData.services) | ||
| .filter(([_, service]: [string, any]) => service.status === 'unhealthy') | ||
| .map(([name, service]: [string, any]) => `• ${name}: ${service.error || 'unhealthy'}`) |
There was a problem hiding this comment.
Add type safety for service entries
Replace any type annotations with proper types for better type safety.
-const failedServices = Object.entries(healthData.services)
- .filter(([_, service]: [string, any]) => service.status === 'unhealthy')
- .map(([name, service]: [string, any]) => `• ${name}: ${service.error || 'unhealthy'}`)
+interface ServiceHealth {
+ status: 'healthy' | 'degraded' | 'unhealthy'
+ error?: string
+ responseTime?: number
+ timestamp?: string
+ details?: Record<string, unknown>
+}
+
+const failedServices = Object.entries(healthData.services as Record<string, ServiceHealth>)
+ .filter(([_, service]) => service.status === 'unhealthy')
+ .map(([name, service]) => `• ${name}: ${service.error || 'unhealthy'}`)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const failedServices = Object.entries(healthData.services) | |
| .filter(([_, service]: [string, any]) => service.status === 'unhealthy') | |
| .map(([name, service]: [string, any]) => `• ${name}: ${service.error || 'unhealthy'}`) | |
| interface ServiceHealth { | |
| status: 'healthy' | 'degraded' | 'unhealthy' | |
| error?: string | |
| responseTime?: number | |
| timestamp?: string | |
| details?: Record<string, unknown> | |
| } | |
| const failedServices = Object.entries(healthData.services as Record<string, ServiceHealth>) | |
| .filter(([_, service]) => service.status === 'unhealthy') | |
| .map(([name, service]) => `• ${name}: ${service.error || 'unhealthy'}`) |
🤖 Prompt for AI Agents
In src/app/api/health/route.ts around lines 22 to 24, the code uses 'any' type
annotations for service entries, which reduces type safety. Define a proper
interface or type for the service object that includes at least 'status' and
'error' properties, then replace the 'any' annotations with this specific type
in the Object.entries callback to ensure better type safety and clearer code.
| const healthChecks = await Promise.allSettled( | ||
| services.map(async (service) => { | ||
| // Use localhost in development, production URL otherwise | ||
| const isDev = process.env.NODE_ENV === 'development' | ||
| const baseUrl = isDev | ||
| ? 'http://localhost:3000' | ||
| : process.env.NEXT_PUBLIC_BASE_URL || 'https://peanut.to' | ||
| const response = await fetchWithSentry(`${baseUrl}/api/health/${service}`, { | ||
| method: 'GET', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| }) | ||
|
|
There was a problem hiding this comment.
Potential architectural issue with self-referential health checks
The aggregated health endpoint makes HTTP calls to its own service's health endpoints through the public URL in production. This could lead to cascading failures or add unnecessary network overhead.
Consider these alternatives:
- Import and call the health check functions directly instead of HTTP calls
- Use a service mesh or internal service discovery
- Use internal URLs that bypass the public internet
Example of direct function calls:
import { GET as getMobulaHealth } from './mobula/route'
import { GET as getSquidHealth } from './squid/route'
// ... other imports
// Then call directly:
const mobulaHealth = await getMobulaHealth()
const mobulaData = await mobulaHealth.json()🤖 Prompt for AI Agents
In src/app/api/health/route.ts around lines 75 to 88, the current implementation
makes HTTP requests to the service's own health endpoints via public URLs, which
can cause cascading failures and unnecessary network overhead. To fix this,
replace these HTTP calls by directly importing and invoking the health check
functions from the respective route files. This avoids network calls by calling
the health check logic internally, improving reliability and performance.
| if (criticalServicesDown || results.summary.unhealthy >= 3) { | ||
| overallStatus = 'unhealthy' |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Replace magic number with named constant
The threshold value of 3 for determining system unhealthiness should be a named constant for better maintainability.
Add at the top of the file:
// System is considered unhealthy if critical services are down OR this many services fail
const UNHEALTHY_SERVICE_THRESHOLD = 3Then update the condition:
-if (criticalServicesDown || results.summary.unhealthy >= 3) {
+if (criticalServicesDown || results.summary.unhealthy >= UNHEALTHY_SERVICE_THRESHOLD) {🤖 Prompt for AI Agents
In src/app/api/health/route.ts around lines 156 to 157, replace the magic number
3 used in the condition checking if the system is unhealthy with a named
constant. Define a constant UNHEALTHY_SERVICE_THRESHOLD with the value 3 at the
top of the file, then update the condition to compare results.summary.unhealthy
against this constant for better code clarity and maintainability.
| ) | ||
| } | ||
|
|
||
| const chainResults: any = {} |
There was a problem hiding this comment.
Define proper type instead of using any
Replace any type with a proper interface for better type safety and code maintainability.
-const chainResults: any = {}
+interface ChainResult {
+ chainId: number
+ providers: Record<string, {
+ status: 'healthy' | 'degraded' | 'unhealthy'
+ responseTime: number
+ blockNumber?: number | null
+ httpStatus?: number
+ error?: string
+ url: string
+ }>
+ overallStatus: 'healthy' | 'degraded' | 'unhealthy' | 'unknown'
+ summary?: {
+ total: number
+ healthy: number
+ degraded: number
+ unhealthy: number
+ }
+}
+
+const chainResults: Record<string, ChainResult> = {}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const chainResults: any = {} | |
| interface ChainResult { | |
| chainId: number | |
| providers: Record<string, { | |
| status: 'healthy' | 'degraded' | 'unhealthy' | |
| responseTime: number | |
| blockNumber?: number | null | |
| httpStatus?: number | |
| error?: string | |
| url: string | |
| }> | |
| overallStatus: 'healthy' | 'degraded' | 'unhealthy' | 'unknown' | |
| summary?: { | |
| total: number | |
| healthy: number | |
| degraded: number | |
| unhealthy: number | |
| } | |
| } | |
| const chainResults: Record<string, ChainResult> = {} |
🤖 Prompt for AI Agents
In src/app/api/health/rpc/route.ts at line 29, replace the use of the `any` type
for the `chainResults` variable with a properly defined interface that
accurately represents the expected structure of the data stored in
`chainResults`. Define this interface above or import it if already defined,
then use it to type `chainResults` to improve type safety and maintainability.
| interface CancelSendLinkModalProps { | ||
| showCancelLinkModal: boolean | ||
| setshowCancelLinkModal: (showCancelLinkModal: boolean) => void | ||
| amount: string | ||
| onClick: () => void | ||
| } | ||
|
|
||
| const CancelSendLinkModal = ({ | ||
| showCancelLinkModal, | ||
| setshowCancelLinkModal, | ||
| amount, | ||
| onClick, | ||
| }: CancelSendLinkModalProps) => { |
There was a problem hiding this comment.
Fix prop naming inconsistency
The setter prop setshowCancelLinkModal doesn't follow camelCase convention. It should be setShowCancelLinkModal to maintain consistency with React naming conventions and the getter prop showCancelLinkModal.
interface CancelSendLinkModalProps {
showCancelLinkModal: boolean
- setshowCancelLinkModal: (showCancelLinkModal: boolean) => void
+ setShowCancelLinkModal: (showCancelLinkModal: boolean) => void
amount: string
onClick: () => void
}
const CancelSendLinkModal = ({
showCancelLinkModal,
- setshowCancelLinkModal,
+ setShowCancelLinkModal,
amount,
onClick,
}: CancelSendLinkModalProps) => {Also update line 19:
- onClose={() => setshowCancelLinkModal(false)}
+ onClose={() => setShowCancelLinkModal(false)}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| interface CancelSendLinkModalProps { | |
| showCancelLinkModal: boolean | |
| setshowCancelLinkModal: (showCancelLinkModal: boolean) => void | |
| amount: string | |
| onClick: () => void | |
| } | |
| const CancelSendLinkModal = ({ | |
| showCancelLinkModal, | |
| setshowCancelLinkModal, | |
| amount, | |
| onClick, | |
| }: CancelSendLinkModalProps) => { | |
| interface CancelSendLinkModalProps { | |
| showCancelLinkModal: boolean | |
| setShowCancelLinkModal: (showCancelLinkModal: boolean) => void | |
| amount: string | |
| onClick: () => void | |
| } | |
| const CancelSendLinkModal = ({ | |
| showCancelLinkModal, | |
| setShowCancelLinkModal, | |
| amount, | |
| onClick, | |
| }: CancelSendLinkModalProps) => { | |
| return ( | |
| <ActionModal | |
| open={showCancelLinkModal} | |
| onClose={() => setShowCancelLinkModal(false)} | |
| // other props... | |
| > | |
| {/* Modal content */} | |
| </ActionModal> | |
| ) | |
| } |
🤖 Prompt for AI Agents
In src/components/Global/CancelSendLinkModal/index.tsx lines 3 to 15, rename the
prop setter from setshowCancelLinkModal to setShowCancelLinkModal to follow
camelCase naming conventions consistent with React standards and the getter prop
showCancelLinkModal. Also update all references to this prop, including the one
on line 19, to use the corrected camelCase name.
| <div className="space-y-2"> | ||
| {!isPeanutWalletUSDC && !selectedTokenAddress && !selectedChainID && ( | ||
| <div className="text-sm font-bold">Select token and chain to pay with</div> | ||
| <div className="text-sm font-bold">Select token and chain to receive</div> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify the UI text change is intentional
The text was changed from "Select token and chain to pay with" to "Select token and chain to receive". This seems semantically incorrect for a payment flow where the user is selecting which token/chain to use for payment. The user pays with a token, not receives it during payment.
Was this change intentional? If so, could you explain the reasoning? Otherwise, consider reverting to the original text:
- <div className="text-sm font-bold">Select token and chain to receive</div>
+ <div className="text-sm font-bold">Select token and chain to pay with</div>🏁 Script executed:
#!/bin/bash
rg -n -C3 "Select token and chain to receive" src/components/Payment/PaymentForm/index.tsxLength of output: 639
Fix the UI text in PaymentForm
The label “Select token and chain to receive” is misleading in the request-payment flow—users are choosing the token/chain they will pay with. Please revert to the original wording.
• File: src/components/Payment/PaymentForm/index.tsx:658
- <div className="text-sm font-bold">Select token and chain to receive</div>
+ <div className="text-sm font-bold">Select token and chain to pay with</div>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <div className="text-sm font-bold">Select token and chain to receive</div> | |
| <div className="text-sm font-bold">Select token and chain to pay with</div> |
🤖 Prompt for AI Agents
In src/components/Payment/PaymentForm/index.tsx at line 658, the label text
"Select token and chain to receive" is misleading for the request-payment flow
because users are actually selecting the token and chain they will pay with.
Change the text back to the original wording that correctly reflects this
action, ensuring the label clearly indicates the token and chain used for
payment.
| .catch((error) => { | ||
| captureException(error) | ||
| console.error('Error claiming link:', error) | ||
| setIsLoading(false) | ||
| }) | ||
| }} |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add user feedback for cancellation errors
The error is captured and logged but users receive no feedback when cancellation fails.
Consider showing an error notification or alert to inform users:
.catch((error) => {
captureException(error)
console.error('Error claiming link:', error)
setIsLoading(false)
+ // Add user notification here, e.g.:
+ // showErrorNotification('Failed to cancel link. Please try again.')
})📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .catch((error) => { | |
| captureException(error) | |
| console.error('Error claiming link:', error) | |
| setIsLoading(false) | |
| }) | |
| }} | |
| .catch((error) => { | |
| captureException(error) | |
| console.error('Error claiming link:', error) | |
| setIsLoading(false) | |
| // Add user notification here, e.g.: | |
| // showErrorNotification('Failed to cancel link. Please try again.') | |
| }) |
🤖 Prompt for AI Agents
In src/components/Send/link/views/Success.link.send.view.tsx around lines 112 to
117, the catch block logs cancellation errors but does not provide any user
feedback. Modify the catch block to display an error notification or alert to
inform users when the cancellation fails, ensuring they are aware of the issue.
Use the existing UI notification system or a simple alert to show the error
message alongside capturing and logging the error.
| setIsLoading(true) | ||
| setshowCancelLinkModal(false) | ||
| sendLinksApi | ||
| .claim(user!.user.username!, transaction.extraDataForDrawer!.link!) |
There was a problem hiding this comment.
Avoid non-null assertions for safer code
Multiple non-null assertions could cause runtime errors if data is unexpectedly missing.
Add proper null checks:
- .claim(user!.user.username!, transaction.extraDataForDrawer!.link!)
+ .claim(
+ user?.user.username || '',
+ transaction.extraDataForDrawer?.link || ''
+ )Or validate before calling:
if (!user?.user.username || !transaction.extraDataForDrawer?.link) {
console.error('Missing required data for claim')
setIsLoading(false)
return
}🤖 Prompt for AI Agents
In src/components/TransactionDetails/TransactionDetailsDrawer.tsx at line 890,
avoid using non-null assertions on user!.user.username! and
transaction.extraDataForDrawer!.link! as they can cause runtime errors if the
data is missing. Instead, add a null check before this line to verify that
user?.user.username and transaction.extraDataForDrawer?.link exist. If either is
missing, log an error, set loading state to false, and return early to prevent
execution with invalid data.
No description provided.