Skip to content

hotfix: make iban non optional #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjramirezn merged 4 commits into from
Aug 27, 2025
Merged

hotfix: make iban non optional #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8eaed3d
fix: bank claim flow runtime error
kushagrasarathe Aug 27, 2025
c4c5cfa
fix: dont have iban as optional
kushagrasarathe Aug 27, 2025
0c9ede8
Merge branch 'peanut-wallet' into hotfix/claim-runtime-error
kushagrasarathe Aug 27, 2025
f99debf
fix: merge conflicts
kushagrasarathe Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/AddWithdraw/DynamicBankAccountForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export type IBankAccountDetails = {
city: string
state: string
postalCode: string
iban?: string
iban: string
country: string
}

Expand Down Expand Up @@ -185,7 +185,7 @@ export const DynamicBankAccountForm = forwardRef<{ handleSubmit: () => void }, D

const result = await onSuccess(payload as AddBankAccountPayload, {
...data,
iban: isIban ? data.accountNumber || iban : undefined,
iban: isIban ? data.accountNumber || iban || '' : '',
accountNumber: isIban ? '' : data.accountNumber,
bic: bic,
country,
Expand Down
18 changes: 11 additions & 7 deletions src/components/Claim/Link/views/BankFlowManager.view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,16 @@ export const BankFlowManager = (props: IClaimScreenProps) => {
name: addBankAccountResponse.data.details.accountOwnerName || user?.user.fullName || '',
iban:
addBankAccountResponse.data.type === 'iban'
? addBankAccountResponse.data.identifier
: undefined,
? addBankAccountResponse.data.identifier || ''
: '',
clabe:
addBankAccountResponse.data.type === 'clabe' ? addBankAccountResponse.data.identifier : '',
addBankAccountResponse.data.type === 'clabe'
? addBankAccountResponse.data.identifier || ''
: '',
accountNumber:
addBankAccountResponse.data.type === 'us' ? addBankAccountResponse.data.identifier : '',
addBankAccountResponse.data.type === 'us'
? addBankAccountResponse.data.identifier || ''
: '',
country: addBankAccountResponse.data.details.countryCode,
id: addBankAccountResponse.data.id,
bridgeAccountId: addBankAccountResponse.data.bridgeAccountId,
Expand Down Expand Up @@ -360,9 +364,9 @@ export const BankFlowManager = (props: IClaimScreenProps) => {

const bankDetails: IBankAccountDetails & { id?: string; bridgeAccountId?: string } = {
name: account.details.accountOwnerName || user?.user.fullName || '',
iban: account.type === 'iban' ? account.identifier : undefined,
clabe: account.type === 'clabe' ? account.identifier : '',
accountNumber: account.type === 'us' ? account.identifier : '',
iban: account.type === 'iban' ? account.identifier || '' : '',
clabe: account.type === 'clabe' ? account.identifier || '' : '',
accountNumber: account.type === 'us' ? account.identifier || '' : '',
country: account.details.countryCode,
id: account.id,
bridgeAccountId: account.bridgeAccountId,
Expand Down
Loading