HOTFIX: Invalid IBAN for UK

[Zishan-7]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	Ready	Preview	Comment	Aug 29, 2025 0:32am

[coderabbitai]

Walkthrough

Adds optional iso2 to CountryData and updates UK entry with iso2. Adjusts getCountryFromIban to match by id or iso2 and changes its return from title to path. Existing fallback by 3-letter code remains.

Changes

Cohort / File(s)	Change summary
Country data typings and entries src/components/AddMoney/consts/index.ts	Added optional iso2 to CountryData; updated United Kingdom entry to include iso2: 'GB'.
Withdraw utils lookup logic src/utils/withdraw.utils.ts	getCountryFromIban now matches country by id or iso2; return value changed from title to path; TODO comment added.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• HOTFIX - IBAN country detection and incorrect bank acc details #1094 — Introduces getCountryFromIban; current PR extends its lookup and alters return value.
• staging country code error #1100 — Modifies country code resolution in withdraw.utils.ts, related to the expanded ISO2 matching.
• hotfix #1012 — Changes countryData structure; related to current addition of iso2 and UK entry update.

Suggested labels

enhancement

Suggested reviewers

• kushagrasarathe
• Hugo0

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/iban-uk

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Zishan-7]

returning path here is better because for countries like United Kingdom path is 'united-kingdom' which matches the selectedCountry variable value

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)

src/components/AddMoney/consts/index.ts (1)

139-147: Document ISO2 requirement and backfill missing ISO3 entries

Add a JSDoc to iso2 in src/components/AddMoney/consts/index.ts (lines 139–147) and supply iso2 values for all ISO3 id entries found without one:

Missing mappings:
ALA→AX, AND→AD, AUT→AT, BEL→BE, BGR→BG, CHE→CH, CYP→CY, CZE→CZ, DEU→DE, DNK→DK, ESP→ES, EST→EE, FIN→FI, FRA→FR, GUF→GF, HRV→HR, HUN→HU, IRL→IE, ISL→IS, ITA→IT, LTU→LT, LUX→LU, LVA→LV, MAF→MF, MLT→MT, MTQ→MQ, NLD→NL, NOR→NO, PRT→PT, REU→RE, ROU→RO, SVK→SK, SVN→SI

 export interface CountryData {
   id: string
   type: 'crypto' | 'country'
   title: string
   currency?: string
   description?: string
   path: string
-  iso2?: string
+  /**
+   * ISO 3166-1 alpha-2 code (e.g., 'GB').
+   * Required when `id` is ISO3 (length 3).
+   */
+  iso2?: string
 }

src/utils/withdraw.utils.ts (2)

3-7: JSDoc now lies; function returns a path slug, not a country name

The return was changed from title to path, but the doc still says “country name”. Update to avoid misuse.

 /**
- * Extracts the country name from an IBAN by parsing the first 2 characters (country code)
+ * Extracts the country from an IBAN (first 2 chars = ISO2) and returns the country path slug.
  * @param iban - The IBAN string (with or without spaces)
- * @returns The country name if found, null if invalid IBAN or country not found
+ * @returns The country path slug (e.g., 'united-kingdom') if found, otherwise null
  */
 export const getCountryFromIban = (iban: string): string | null => {
@@
-  return country ? country.path : null
+  return country ? country.path : null
 }

Also applies to: 26-26

---

9-14: Guard against short/invalid IBAN prefixes before substring

Prevents false matches on strings shorter than 2 chars or non-letter prefixes.

   // Remove spaces and convert to uppercase
   const cleanIban = iban.replace(/\s/g, '').toUpperCase()

-  // Extract the first 2 characters as country code
-  const countryCode = cleanIban.substring(0, 2)
+  // Extract the first 2 characters as country code
+  if (cleanIban.length < 2 || !/^[A-Z]{2}/.test(cleanIban)) {
+    return null
+  }
+  const countryCode = cleanIban.substring(0, 2)

🧹 Nitpick comments (1)

src/utils/withdraw.utils.ts (1)

16-16: Replace inline TODO with tracked issue

“// @dev TODO - fix the UK issue properly” should link to an issue with scope (full ISO2 backfill or normalization).

I can open a follow-up ticket and outline options: (a) backfill iso2 for all ISO3 ids, (b) derive iso2 at runtime from countryCodeMap.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 04e2142 and 47ae25b.

📒 Files selected for processing (2)

• src/components/AddMoney/consts/index.ts (2 hunks)
• src/utils/withdraw.utils.ts (2 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/components/AddWithdraw/DynamicBankAccountForm.tsx:279-279
Timestamp: 2025-08-14T08:02:26.705Z
Learning: For hotfixes in the peanut-ui codebase, prefer generic error messages over specific validation error details until the copy can be reviewed with the team, even when the validation functions return detailed error messages.

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/components/Claim/Link/views/BankFlowManager.view.tsx:0-0
Timestamp: 2025-08-14T14:36:18.758Z
Learning: Bridge API requires ISO3 country codes (3-letter codes like "USA", "GBR") while flag display components need ISO2 codes (2-letter codes like "US", "GB").

📚 Learning: 2025-08-14T14:42:54.411Z

Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.411Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.

Applied to files:

• src/utils/withdraw.utils.ts
• src/components/AddMoney/consts/index.ts

📚 Learning: 2025-05-22T15:38:48.586Z

Learnt from: kushagrasarathe
PR: peanutprotocol/peanut-ui#869
File: src/app/(mobile-ui)/withdraw/page.tsx:82-88
Timestamp: 2025-05-22T15:38:48.586Z
Learning: The country-specific withdrawal route exists at src/app/(mobile-ui)/withdraw/[...country]/page.tsx and renders the AddWithdrawCountriesList component with flow="withdraw".

Applied to files:

• src/utils/withdraw.utils.ts

🧬 Code graph analysis (1)

src/utils/withdraw.utils.ts (1)

src/components/AddMoney/consts/index.ts (1)

• countryData (256-1945)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (3)

src/components/AddMoney/consts/index.ts (1)

776-782: GBR entry now includes iso2: 'GB' — good for IBAN and flags

This aligns with IBAN’s ISO2 prefix and our flags. No further changes needed here for the hotfix.

src/utils/withdraw.utils.ts (2)

15-17: Lookup by id OR iso2 resolves UK detection edge case

Using c.id === countryCode || c.iso2 === countryCode is a safe, minimal hotfix and keeps existing ISO3 fallback intact.

---

16-16: Audit getCountryFromIban call sites for slug vs title mismatch
DynamicBankAccountForm.tsx:328 now compares the slug (country.path) returned by getCountryFromIban against a human‐readable name—update the logic or test expectations (e.g. GB → 'united-kingdom'). Search for any other uses of getCountryFromIban and adjust them and their tests to expect the slug instead of the title.