[TASK-14416] fix: Remove 'Estimate' text from exchange rate widget#1220
[TASK-14416] fix: Remove 'Estimate' text from exchange rate widget#1220Zishan-7 merged 1 commit intopeanut-wallet-devfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved the word “Estimate.” from the delivery time UI text in ExchangeRateWidget. The memoized deliveryTimeText still branches on destination currency (USD vs others) to display hours vs minutes, but both resulting strings no longer include “Estimate.”. No public API or export signatures changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Global/ExchangeRateWidget/index.tsx (1)
93-95: Make currency check case‑insensitive to avoid URL casing mismatches.If users land with
to=usd, the current strict check won’t match. Normalize before comparing.Apply this diff:
- return destinationCurrency === 'USD' ? 'Should arrive in hours.' : 'Should arrive in minutes.' + const isUSD = destinationCurrency?.toUpperCase() === 'USD' + return isUSD ? 'Should arrive in hours.' : 'Should arrive in minutes.'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Global/ExchangeRateWidget/index.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (1)
src/components/Global/ExchangeRateWidget/index.tsx (1)
93-95: Scope-correct change: “Estimate” removed as requested.Text now reads cleanly without “Estimate.” and keeps existing USD vs non‑USD branching. No behavioral side effects.
No description provided.