Skip to content

[TASK-14416] fix: Remove 'Estimate' text from exchange rate widget#1220

Merged
Zishan-7 merged 1 commit intopeanut-wallet-devfrom
fix/remove-estimate-exchange-rate
Sep 16, 2025
Merged

[TASK-14416] fix: Remove 'Estimate' text from exchange rate widget#1220
Zishan-7 merged 1 commit intopeanut-wallet-devfrom
fix/remove-estimate-exchange-rate

Conversation

@Zishan-7
Copy link
Contributor

No description provided.

@Zishan-7 Zishan-7 requested a review from Hugo0 September 16, 2025 11:12
@vercel
Copy link

vercel bot commented Sep 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
peanut-wallet Ready Ready Preview Comment Sep 16, 2025 11:17am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

Walkthrough

Removed the word “Estimate.” from the delivery time UI text in ExchangeRateWidget. The memoized deliveryTimeText still branches on destination currency (USD vs others) to display hours vs minutes, but both resulting strings no longer include “Estimate.”. No public API or export signatures changed.

Changes

Cohort / File(s) Summary of Changes
Exchange rate widget UI text
src/components/Global/ExchangeRateWidget/index.tsx
Updated deliveryTimeText: removed “Estimate.” from both branches; retained conditional logic for USD (hours) vs other currencies (minutes).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • Hugo0

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request has no author-provided description, so it does not document the change or provide context and therefore fails this check; the raw summary shows the change (removing "Estimate" from the ExchangeRateWidget deliveryTimeText) but that information is not present in the PR description. A brief description is needed to explain intent, scope, and any verification performed. Please add a short PR description stating that the change removes the word "Estimate" from the exchange rate widget, why the change was made, and any testing or verification steps (e.g., manual steps or screenshots); a one-paragraph summary is sufficient for this small change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[TASK-14416] fix: Remove 'Estimate' text from exchange rate widget" directly describes the primary change (removing the "Estimate" text) observed in ExchangeRateWidget/index.tsx, is concise and focused, and includes a task ID that aids traceability. It clearly summarizes the main developer intent and is appropriate for a teammate scanning the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-estimate-exchange-rate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@notion-workspace
Copy link

@coderabbitai coderabbitai bot added the enhancement New feature or request label Sep 16, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/Global/ExchangeRateWidget/index.tsx (1)

93-95: Make currency check case‑insensitive to avoid URL casing mismatches.

If users land with to=usd, the current strict check won’t match. Normalize before comparing.

Apply this diff:

-    return destinationCurrency === 'USD' ? 'Should arrive in hours.' : 'Should arrive in minutes.'
+    const isUSD = destinationCurrency?.toUpperCase() === 'USD'
+    return isUSD ? 'Should arrive in hours.' : 'Should arrive in minutes.'
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d68ea6d and d1952d4.

📒 Files selected for processing (1)
  • src/components/Global/ExchangeRateWidget/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Deploy-Preview
🔇 Additional comments (1)
src/components/Global/ExchangeRateWidget/index.tsx (1)

93-95: Scope-correct change: “Estimate” removed as requested.

Text now reads cleanly without “Estimate.” and keeps existing USD vs non‑USD branching. No behavioral side effects.

@Zishan-7 Zishan-7 merged commit 73494a7 into peanut-wallet-dev Sep 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants