[TASK-14493] feat: show local currency exchange rate in claim to bank confirm view#1221
Merged
Zishan-7 merged 3 commits intopeanut-wallet-devfrom Sep 17, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughReplaces a deep currency-conversion flow in the bank-claim confirm view with a direct mapping to a non-Euro currency via Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
src/components/ExchangeRate/index.tsx (1)
13-18: Typo and unnecessary parseFloat; simplify and harden formatting.
- Rename nonEruoExchangeRate → nonEuroExchangeRate.
- Use number formatting directly and guard against 0.
Apply:
- const { exchangeRate: nonEruoExchangeRate, isLoading } = useExchangeRate({ + const { exchangeRate: nonEuroExchangeRate, isLoading } = useExchangeRate({ sourceCurrency, destinationCurrency: nonEuroCurrency || 'EUR', initialSourceAmount: 1, enabled: !!nonEuroCurrency, }) ... - if (nonEuroCurrency) { - displayValue = nonEruoExchangeRate - ? `1 ${sourceCurrency} = ${parseFloat(nonEruoExchangeRate.toString()).toFixed(4)} ${nonEuroCurrency}` - : '-' + if (nonEuroCurrency) { + displayValue = + nonEuroExchangeRate > 0 + ? `1 ${sourceCurrency} = ${nonEuroExchangeRate.toFixed(4)} ${nonEuroCurrency}` + : '-' isLoadingRate = isLoadingAlso applies to: 30-34
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (2)
95-101: Filtering logic is brittle; scope to IBAN and exclude EUR/comingSoon.
- The variable name/comment don’t match behavior.
- Hard‑coded exclusion list will drift.
- Limit to IBAN countries, skip EUR, skip comingSoon.
-// Array for non-European countries, we show usd -> local currency exchange rate for these countries -const nonEuropeanCountries = ['mx', 'us', 'br', 'ar'] -const nonEuroCurrency = countryCurrencyMappings.find( - (currency) => - !nonEuropeanCountries?.includes(currency.flagCode.toLowerCase()) && - countryCodeForFlag.toLowerCase() === currency.flagCode.toLowerCase() -)?.currencyCode +// For IBAN recipients that aren’t EUR countries, show source -> local currency rate +const nonEuroCurrency = useMemo(() => { + if (accountType !== AccountType.IBAN) return undefined + const code = countryCodeForFlag.toLowerCase() + const entry = countryCurrencyMappings.find( + (c) => c.flagCode.toLowerCase() === code && c.currencyCode !== 'EUR' && !c.comingSoon + ) + return entry?.currencyCode +}, [accountType, countryCodeForFlag])Rename nonEuropeanCountries → excludedCountryFlags if you keep the old approach.
103-104: Remove stray console logs.These will leak PII/debug noise in production.
-console.log(claimLinkData) -console.log(nonEuroCurrency)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx(3 hunks)src/components/ExchangeRate/index.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-12T17:47:28.362Z
Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1089
File: src/app/api/bridge/exchange-rate/route.ts:4-19
Timestamp: 2025-08-12T17:47:28.362Z
Learning: In the Bridge exchange rate API route (src/app/api/bridge/exchange-rate/route.ts), the ExchangeRateResponse interface uses numeric types for rates because the route converts string values from the Bridge API to floats using parseFloat() before returning the response.
Applied to files:
src/components/ExchangeRate/index.tsx
📚 Learning: 2025-08-14T14:42:54.411Z
Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.411Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
📚 Learning: 2024-11-18T21:36:11.486Z
Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#535
File: src/components/Claim/Claim.tsx:142-146
Timestamp: 2024-11-18T21:36:11.486Z
Learning: In `src/components/Claim/Claim.tsx`, external calls like token price fetching and cross-chain details retrieval are already encapsulated within existing `try...catch` blocks, so additional error handling may be unnecessary.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
🧬 Code graph analysis (2)
src/components/ExchangeRate/index.tsx (2)
src/hooks/useGetExchangeRate.tsx (1)
useGetExchangeRate(14-55)src/hooks/useExchangeRate.ts (1)
useExchangeRate(26-150)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)
src/constants/countryCurrencyMapping.ts (1)
countryCurrencyMappings(10-48)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (2)
src/components/ExchangeRate/index.tsx (1)
8-11: Public API change: add sourceCurrency with sane default.Looks good. Since this alters a shared component’s props, confirm all call sites are still type‑safe and behaviorally correct (storybook/tests too).
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)
135-139: Confirm intended source currency for local-rate display.You pass sourceCurrency={currencyCode} (EUR for IBAN). The comment above says “usd -> local currency.” If the requirement is USD→local, pass 'USD'; if it’s bank‑base→local, current code is fine.
Option if USD→local is desired:
- <ExchangeRate - accountType={accountType} - nonEuroCurrency={nonEuroCurrency} - sourceCurrency={currencyCode} - /> + <ExchangeRate + accountType={accountType} + nonEuroCurrency={nonEuroCurrency} + sourceCurrency="USD" + />
kushagrasarathe
approved these changes
Sep 17, 2025
Contributor
kushagrasarathe
left a comment
kushagrasarathe
left a comment
There was a problem hiding this comment.
@Zishan-7 left two comments, one is actionable (comment one), rest lgtm
kushagrasarathe
requested changes
Sep 17, 2025
Contributor
kushagrasarathe
left a comment
kushagrasarathe
left a comment
There was a problem hiding this comment.
actually @Zishan-7 some issues with the pr, pining on discord
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)
16-16: Incorrect import: named export used as default (runtime undefined).countryCurrencyMappings is a named export. Default-importing it yields
undefined, breaking.find(...).-import countryCurrencyMappings from '@/constants/countryCurrencyMapping' +import { countryCurrencyMappings } from '@/constants/countryCurrencyMapping'
🧹 Nitpick comments (2)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (2)
62-64: Memoize and guard the currency lookup.Minor polish: compute once per
countryCodeForFlagchange and keep the code resilient to unknown flags.- const nonEuroCurrency = countryCurrencyMappings.find( - (currency) => countryCodeForFlag.toLowerCase() === currency.flagCode.toLowerCase() - )?.currencyCode + const nonEuroCurrency = useMemo(() => { + const match = countryCurrencyMappings.find( + (c) => c.flagCode.toLowerCase() === countryCodeForFlag.toLowerCase() + ) + return match?.currencyCode + }, [countryCodeForFlag])
56-60: Variable name is misleading: this is token units, not USD.
formatUnits(...)returns the token amount, not a USD amount. Rename to avoid confusion and keep types clear; confirmPeanutActionDetailsCard.amountaccepts a string.- const usdAmount = useMemo( + const tokenAmount = useMemo( () => formatUnits(claimLinkData?.amount ?? 0, claimLinkData?.tokenDecimals) || '0.00', [claimLinkData] ) ... - amount={usdAmount} + amount={tokenAmount}To verify the prop type:
- Check
PeanutActionDetailsCardprop foramount(string vs number) and any internal formatting.Also applies to: 78-79
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx(4 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-14T14:42:54.411Z
Learnt from: Zishan-7
PR: peanutprotocol/peanut-ui#1094
File: src/utils/withdraw.utils.ts:181-191
Timestamp: 2025-08-14T14:42:54.411Z
Learning: The countryCodeMap in src/components/AddMoney/consts/index.ts uses uppercase 3-letter country codes as keys (like 'AUT', 'BEL', 'CZE') that map to 2-letter country codes, requiring input normalization to uppercase for proper lookups.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
📚 Learning: 2024-11-18T21:36:11.486Z
Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#535
File: src/components/Claim/Claim.tsx:142-146
Timestamp: 2024-11-18T21:36:11.486Z
Learning: In `src/components/Claim/Claim.tsx`, external calls like token price fetching and cross-chain details retrieval are already encapsulated within existing `try...catch` blocks, so additional error handling may be unnecessary.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
📚 Learning: 2024-12-11T10:13:22.806Z
Learnt from: jjramirezn
PR: peanutprotocol/peanut-ui#564
File: src/components/Request/Pay/Views/Initial.view.tsx:430-430
Timestamp: 2024-12-11T10:13:22.806Z
Learning: In the React TypeScript file `src/components/Request/Pay/Views/Initial.view.tsx`, when reviewing the `InitialView` component, do not flag potential issues with using non-null assertion `!` on the `slippagePercentage` variable, as handling undefined values in this context is considered out of scope.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
📚 Learning: 2024-10-08T20:13:42.967Z
Learnt from: Hugo0
PR: peanutprotocol/peanut-ui#413
File: src/components/Request/Pay/Views/Initial.view.tsx:71-72
Timestamp: 2024-10-08T20:13:42.967Z
Learning: In `src/components/Request/Pay/Views/Initial.view.tsx`, it's acceptable to use the `!` operator in TypeScript to assert that `selectedTokenData` is not `null` or `undefined`, and potential runtime errors from accessing its properties without checks can be disregarded.
Applied to files:
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx
🧬 Code graph analysis (1)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)
src/constants/countryCurrencyMapping.ts (1)
countryCurrencyMappings(10-48)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (1)
src/components/Claim/Link/views/Confirm.bank-claim.view.tsx (1)
94-94: No change — callsite is correct.
src/components/ExchangeRate/index.tsx: IExchangeRateProps includes nonEuroCurrency?: string and sourceCurrency?: string (sourceCurrency defaults to 'USD'); the component maps nonEuroCurrency to destinationCurrency, so passing nonEuroCurrency at the callsite is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.