[TASK-14950] fix: Existing account error not shown on withdraw

[Zishan-7]

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	Ready	Preview	Comment	Sep 24, 2025 7:02am

[notion-workspace]

🪲 Bug: error message for when a bank account is used by another user is missed

[coderabbitai]

Walkthrough

Removed a useEffect from DynamicBankAccountForm.tsx that previously cleared submissionError when the form was valid and BIC was present. No exported APIs changed. Debounced BIC-related validation remains.

Changes

Cohort / File(s)	Summary of Changes
Form error-state handling src/components/AddWithdraw/DynamicBankAccountForm.tsx	Removed useEffect that auto-cleared submissionError based on isValid and BIC presence; retained debounced BIC validation behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: always show BIC input in ui #1168 — Also changes the BIC-related effect clearing submissionError in DynamicBankAccountForm.tsx.
• fix: bank claim flow runtime error #1138 — Touches the same effect, reversing/adjusting auto-clear logic for submissionError with BIC presence.
• [TASK-14287] fix: stop cleaning error by bic field #1159 — Modifies the same submissionError-clearing useEffect in DynamicBankAccountForm.tsx.

Suggested labels

enhancement

Suggested reviewers

• kushagrasarathe
• jjramirezn

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly states the primary fix — an existing account error not showing during withdraw — and corresponds to the change in DynamicBankAccountForm that alters submissionError handling; it is clear, concise, and specific enough for a teammate to understand the main intent of the PR.
Description Check	✅ Passed	The PR description contains only an image attachment with no textual detail, but the image is recorded in the PR objectives and is plausibly related to the UI bug fixed by changes to submissionError handling, so the description is related to the changeset and meets the lenient pass criteria.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/existing-acc-error

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a18dff and 28311f6.

📒 Files selected for processing (1)

• src/components/AddWithdraw/DynamicBankAccountForm.tsx (0 hunks)

💤 Files with no reviewable changes (1)

• src/components/AddWithdraw/DynamicBankAccountForm.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}