Skip to content

fix: await history entries#1276

Merged
jjramirezn merged 1 commit intopeanut-wallet-devfrom
fix/history
Oct 3, 2025
Merged

fix: await history entries#1276
jjramirezn merged 1 commit intopeanut-wallet-devfrom
fix/history

Conversation

@jjramirezn
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
peanut-wallet Building Building Preview Comment Oct 3, 2025 0:17am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated fetchHistory in src/hooks/useTransactionHistory.ts to await Promise.all over completeHistoryEntry-mapped entries, ensuring all asynchronous per-entry transformations resolve before returning the HistoryResponse. No exported API signatures changed.

Changes

Cohort / File(s) Summary of Changes
Transaction history hook
src/hooks/useTransactionHistory.ts
Wraps data.entries.map(completeHistoryEntry) with Promise.all and awaits the result, changing entries from a potential array of Promises to a fully resolved array prior to return.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/history

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b83becf and f70ac7b.

📒 Files selected for processing (1)
  • src/hooks/useTransactionHistory.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@beetrootw beetrootw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jjramirezn jjramirezn merged commit 4ec9ff1 into peanut-wallet-dev Oct 3, 2025
3 of 5 checks passed
@vercel vercel bot temporarily deployed to Preview – peanut-wallet October 3, 2025 00:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants