Merged
Conversation
**External Nodes Visualization:** - Add external nodes for wallets, banks, and merchants - Distinct shapes: diamond (wallet), square (bank), hexagon (merchant) - Animated particles flowing user → external - Color-coded by type with dashed links - Click behavior: wallet→Arbiscan, merchant→Google, bank→nothing - Tooltips show full account numbers with type detection - Error handling with retry capability **Bank Account Type Detection:** - New inferBankAccountType() utility in bridge.utils - Detects: SPEI (CLABE), ACH, SEPA (IBAN), PIX, CBU/CVU - Supports CPF/CNPJ, email, phone PIX keys - Comprehensive Latin American payment methods **Graph Preferences Persistence:** - New useGraphPreferences hook with localStorage - Auto-saves all settings with 1sec debounce - Migrates old preferences (agePositioning → center) - Restores on page load **Force Simulation Improvements:** - Unified center force with sizeBias parameter - External links force for shared wallet/bank clustering - Simplified charge force (removed complex distance scaling) - Better collision detection with softer constraints - Per-link-type strength (invite/P2P/external) - Fixed pointer areas for better hover detection **UI Improvements:** - Added error states for external nodes fetch - Better loading indicators - Cleaner force config sliders with multiplier display - Improved recalculate button behavior **Architecture:** - Cleaner data filtering (visibilityConfig removes from simulation) - Fixed infinite loop issues with preferences - Better force reconfiguration on data changes - Removed hideInactive (replaced by visibilityConfig) **Security:** - Error handling prevents infinite loading - No sensitive data in localStorage - Admin-only data exposure
…ovements - Add kycRegions field to GraphNode interface (was missing, causing type mismatch) - Unified center force with sizeBias parameter (replaces old centerGravity + sizeBasedCenter) - Simplified charge force (removed complex distance scaling) - Better collision detection with softer constraints - Per-link-type strength for invite/P2P/external edges - Format code with prettier
- Add limit field to ExternalNodesConfig type - Pass limit to getExternalNodes API call - Default: 5000 (can be adjusted by user if needed) - Allows control over performance vs data completeness
…ternal-nodes feat(invite-graph): External nodes, preferences, and force improvements
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis PR expands the invite graph visualization system with support for peer-to-peer edges, external payment nodes, configurable force simulation parameters, activity-based filtering, and preference persistence via localStorage. The changes span the graph component, API service layer, supporting utilities, and the UI layer consuming the expanded component API. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.