fix: address CodeRabbit findings from backmerge PR#1705
Merged
Conversation
- update-content.yml: stage src/content before git write-tree so the commit captures the updated submodule SHA (was silently snapshotting the old pointer) - blog.ts: escape HTML in code block fallback to prevent XSS - Delete scripts/ping-sitemap.sh — Google and Bing ping endpoints have been deprecated since 2022/2023 (replaced by IndexNow)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughAdds a git staging step in the GitHub Actions workflow before creating the Git tree, removes the sitemap-ping script, and changes the blog code block fallback to escape HTML entities in unhighlighted code. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 valid findings from CodeRabbit review on #1703 (backmerge PR):
update-content.yml: Addgit add src/contentbeforegit write-tree— the submodule checkout updates the working tree but not the parent index, so commits were silently snapshotting the old submodule SHAblog.ts: Escape HTML in shiki fallback code blocks to prevent XSS when an unsupported language falls throughscripts/ping-sitemap.sh: Google's ping endpoint deprecated June 2023, Bing's May 2022 — both return 404. Already replaced by IndexNowSkipped (not worth fixing)
<button>inside<a>— valid HTML spec issue but requires addingasChildto Button component (larger refactor)