#41 Replace console commandline#42
Conversation
…impleConsoleWrapper` and introduce `PinCliParameters` for argument parsing.
…esting conflicts
…package versions
…ation in `ExportPrivateKeyTest`.
… definition. Simplify `PinEntry` class by eliminating unused XML-based CLI parsing functionality.
| } | ||
|
|
||
| if ($filename != '') { | ||
| if (($this->logFile = fopen($filename, 'w')) === false) { |
There was a problem hiding this comment.
wb was one of the warning i have. i have a lot of inspections running and did not even react to most warnings.
i can revert this if wanted.
| . 'for writing.' . PHP_EOL, | ||
| self::VERBOSITY_ERRORS | ||
| ); | ||
| exit(1); |
There was a problem hiding this comment.
i just removed the else. because object calistenics / google coding standard. if you are more a dijkstra fan i can add the else again.
you need to scroll a bit down and you see it was not removed just the "else clause" and the dead code.
…eyTest` and `SimpleCliWrapper`.
| @@ -0,0 +1,184 @@ | |||
| <?php | |||
|
|
|||
| namespace Console; | |||
There was a problem hiding this comment.
The namespace should probably be Crypt/Console.
|
The only problem with it I have is that I have no easy way to test it. The CI is using GnuPG 2.4, but this console pin entry is used only with GnuPG 2.0 up to 2.1.12. |
|
Fair, i mean in theory this is a helper tool and we can just add it as an information ;D ... and for testing if you look at it i literally just changed the first parameters to be passed and replaced the output formatting. so if it was broken before it remains broken and if not it's not. it is really mainly "pass those 2 params" and "echo that" but if you find something I am swamped this week with work. so I have time next week to think about this earliest. |
|
so do we remove it? do we just add a comment? you know ... "works for"? I am willing to do the work if it's doable in a reasonable timeframe |
2 participants
#41 replacing abandoned pear/console_commandline