Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds queue flushing support to the TelemetryDeck Vue hook API and updates the demo/tests/tooling to reflect the new flush/safeFlush methods.
Changes:
- Extend
useTelemetryDeck()withflush()andsafeFlush()(+ error meta updates). - Update demo app + unit tests to exercise
flush/safeFlushand improved UI/test structure. - Introduce Prettier config/scripts and enforce formatting in CI.
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/hooks/index.ts |
Adds flush/safeFlush and updates method typing for error meta. |
src/tests/hooks.test.ts |
Extends safe/raw method tests to include flush behavior. |
src/tests/plugin.test.ts |
Verifies plugin onError integration also covers safe flush errors. |
src/App.vue |
Expands demo UI to trigger signal/queue/flush + safe variants and show status. |
src/tests/App.test.ts |
Refactors demo tests and adds coverage for flush + error event display. |
src/main.ts |
Adds demo onError handler that dispatches a telemetrydeck:error event. |
README.md |
Documents flushing queued events and adds formatting commands. |
prettier.config.js, .prettierignore |
Adds shared Prettier config and ignore list. |
.github/workflows/*.yml |
Adds format:check step to CI workflows. |
| Config/style miscellany | Formatting updates + demo styling adjustments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
flushandsafeFlushfromuseTelemetryDeck()add getQueueCount - to return number of events in the queue
Add tests for raw
flush,safeFlush, and plugin-levelonErrorhandlingUpdate the local demo page with clearer controls for signal, queue, flush, safe methods, client user changes, and visible action/result/error state
Add to demo page
onErrorto test safe command onError callbackOther updates