Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
Improves the library’s TypeScript surface by exporting named hook/method types (and SDK payload/options types), and adds an export/type smoke test to catch regressions in the published package’s typings.
Changes:
- Export
TelemetryDeckHooksplus named method types (TelemetryDeckSignal,TelemetryDeckSafeSignal, etc.) fromsrc/hooks, and re-exportTelemetryDeckOptions/TelemetryDeckPayloadfrom@telemetrydeck/sdk. - Update internal tests to use the new named
TelemetryDeckHookstype instead ofReturnType<typeof useTelemetryDeck>. - Add a
tsc-based exports/type smoke test and wire it intotest:exports.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/exports/types.ts | Adds a TS smoke test that validates the package exports the new public types and they’re usable together. |
| tests/exports/tsconfig.json | Adds a dedicated TS config for the exports typecheck. |
| src/tests/plugin.test.ts | Switches VM typing to the newly exported TelemetryDeckHooks. |
| src/tests/hooks.test.ts | Switches VM typing to the newly exported TelemetryDeckHooks. |
| src/hooks/index.ts | Introduces and exports named public hook/method types and re-exports SDK payload/options types. |
| README.md | Documents the new public TypeScript helper types with a usage example. |
| package.json | Extends test:exports to run tsc on the new type smoke test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the library’s TypeScript surface by exporting named hook/method types (and SDK payload/options types), and adds an export/type smoke test to catch regressions in the published package’s typings.
Changes:
Export TelemetryDeckHooks plus named method types (TelemetryDeckSignal, TelemetryDeckSafeSignal, etc.) from src/hooks, and re-export TelemetryDeckOptions/TelemetryDeckPayload from @telemetrydeck/sdk.
Update internal tests to use the new named TelemetryDeckHooks type instead of ReturnType.
Add a tsc-based exports/type smoke test and wire it into test:exports.