fix: use tsdown library packaging#25
Merged
Merged
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the library packaging pipeline from Rollup to tsdown, updating build configuration and package metadata to publish dual ESM/CJS outputs with generated declaration files.
Changes:
- Replace Rollup build with
tsdown(newtsdown.config.ts, removerollup.config.js, updatenpm run build). - Update package exports/types and smoke checks to match new output file names (
.mjs/.cjsand.d.mts/.d.cts). - Adjust internal entrypoints/import specifiers to include explicit
.jspaths for ESM-friendly resolution.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsdown.config.ts | Adds tsdown build configuration (formats, dts, externals, extensions). |
| tsconfig.build.json | Simplifies TS build config now that tsdown drives output and dts generation. |
| tests/pack/contents.mjs | Updates pack test to require new declaration output filenames. |
| src/plugin/index.ts | Updates internal type import to explicit index.js path. |
| rollup.config.js | Removes old Rollup build configuration. |
| package.json | Switches build script to tsdown and updates exports/types metadata accordingly. |
| package-lock.json | Locks updated dependency graph for tsdown and removed Rollup tooling. |
| index.ts | Updates published entrypoint exports/imports to explicit index.js paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the library packaging pipeline from Rollup to tsdown, updating build configuration and package metadata to publish dual ESM/CJS outputs with generated declaration files.
Changes:
Replace Rollup build with tsdown (new tsdown.config.ts, remove rollup.config.js, update npm run build).
Update package exports/types and smoke checks to match new output file names (.mjs/.cjs and .d.mts/.d.cts).
Adjust internal entrypoints/import specifiers to include explicit .js paths for ESM-friendly resolution.