test(serve): add coverage for unregistered token webhook fix (#23)#34
Open
test(serve): add coverage for unregistered token webhook fix (#23)#34
Conversation
Add TestHandleCanary_unregisteredTokenNoWebhook to verify that processAlert returns early without firing a webhook when the token is not registered in the DB. Add the positive counterpart TestHandleCanary_registeredTokenFiresWebhook to confirm registered tokens do trigger webhook delivery. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two tests for the fix in #24:
TestHandleCanary_unregisteredTokenNoWebhook— fires a request for a token not in DB, verifies 200 pixel response and webhook is NOT calledTestHandleCanary_registeredTokenFiresWebhook— registers a token, fires request, verifies webhook IS called