Add tests for core session management methods#57
Merged
Conversation
Add comprehensive test coverage for previously untested methods: - session_expired?: tests for expired, not expired, and unset sessions - signing_in?: tests for POST/GET to sign_in_path and other paths - handle_session_reset: tests that reset_session is called - Session timeout behavior: tests for session expiration logic including custom timeout values, current_user.auto_timeout, and active_url skipping
Ruby 3.4 removed mutex_m from the standard library, but older Rails versions (like 5.1) depend on it. This fixes the LoadError when running tests with Rails 5.1 on Ruby 3.4.
pelargir
force-pushed
the
add-more-tests
branch
from
6ac2b71 to
f042bc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive test coverage for previously untested methods:
session_expired?: tests for expired, not expired, and unset sessionssigning_in?: tests for POST/GET to sign_in_path and other pathshandle_session_reset: tests that reset_session is calledcurrent_user.auto_timeout, andactive_urlskipping