Move baseimage from Node.js 10 to mainline (Node.js 12)#4
Merged
orangejulius merged 1 commit intomasterfrom Mar 13, 2020
Merged
Move baseimage from Node.js 10 to mainline (Node.js 12)#4orangejulius merged 1 commit intomasterfrom
orangejulius merged 1 commit intomasterfrom
Conversation
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers. Connects pelias/interpolation#245 Connects pelias/pelias#800
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between node-postal and Node.js 12.
We are now using a Node.js 12 compatible fork of the
node-postallibrary, so we can now bring the libpostal baseimage back to parity with the other Docker images.This will reduce complexity, maintenance times, and download sizes for Pelias containers.
Connects pelias/interpolation#245
Connects pelias/pelias#800