multicore http server#250
Draft
missinglink wants to merge 8 commits intomasterfrom
Draft
Conversation
Member
Author
|
@orangejulius I did some basic testing on this and found that using multicore and libpostal service resulted in worse performance than running it single-threaded using the npm module. Maybe there's an error in how I'm using the async code or something else going on? |
Member
|
Yeah, I recall experiencing and reading about poor performance from the After all, it's essentially a load balancing layer where different Node.js processes are communicating with each other. I imagine it's not nearly as efficient as say, Nginx in front of several identical Node.js processes reading from the same SQLite DB. |
afc85ab to
d4678cf
Compare
d4678cf to
dadecb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is #249 plus a single commit to add multi-core support to the http server via the
clustermodule.When using the
node-postal'module' adapter it is recommended to set the env varCPUS=1to force the server single-threaded.