Open
Conversation
ghost
assigned
Contributor
|
I think until we switch to using libpostal as a service we shouldn't merge this. It would just complicate things and we'd get more support questions than benefits. |
Contributor
|
Closing for the time being. |
Member
|
We definitely should re-evaluate this after #146 is merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR enables multicore support for the interpolation service.
I do not think this should be merged in its current state due to:
We could consider defaulting to
1process instead ofos.cpus().lengthand then allow ops engineers to modify the setup to suit their environment using theCPUSenv var.Thoughts?