Skip to content

update default module.shard.complexity to 500 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
missinglink wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update default module.shard.complexity to 500 #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/cmd/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ module.exports = {
})
yargs.option('tweak_module_shard_complexity', {
type: 'number',
default: 200,
default: 500,
coerce: parseFloat,
describe: 'max polygon complexity for shard module'
})
Expand Down
2 changes: 1 addition & 1 deletion module/shard/TriggerGeometryInsert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class TriggerGeometryInsert extends SqliteStatement {
create (db, config) {
try {
let dbname = _.get(config, 'database', 'main')
let complexity = _.clamp(_.get(config, 'module.shard.complexity', 200), 5, 1000000)
let complexity = _.clamp(_.get(config, 'module.shard.complexity', 500), 5, 1000000)
let simplify = _.get(config, 'module.shard.simplify', 0.0001)
db.prepare(`
CREATE TRIGGER IF NOT EXISTS shard_geometry_insert
Expand Down
8 changes: 3 additions & 5 deletions module/shard/TriggerGeometryInsert.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ tap.test('definition', (t) => {

-- insert collection into tmp table
INSERT INTO shard_subdivide (geom)
SELECT ST_Subdivide(ST_SimplifyPreserveTopology(NEW.geom, 0.0001), 200)
SELECT ST_Subdivide(ST_SimplifyPreserveTopology(NEW.geom, 0.0001), 500)
WHERE NEW.geom IS NOT NULL;

-- insert shards in to shard table
Expand Down Expand Up @@ -177,8 +177,7 @@ tap.test('functional - boundary', (t) => {
{ element: 34 },
{ element: 35 },
{ element: 36 },
{ element: 37 },
{ element: 38 }
{ element: 37 }
], 'split')

t.end()
Expand Down Expand Up @@ -254,8 +253,7 @@ tap.test('functional - buffer', (t) => {
{ element: 34 },
{ element: 35 },
{ element: 36 },
{ element: 37 },
{ element: 38 }
{ element: 37 }
], 'split')

t.end()
Expand Down