pelias pip - 'hoist' layers from pure pip results if not present in hierarchy#127
Merged
missinglink merged 3 commits intomasterfrom Oct 3, 2025
Merged
pelias pip - 'hoist' layers from pure pip results if not present in hierarchy#127missinglink merged 3 commits intomasterfrom
missinglink merged 3 commits intomasterfrom
Conversation
Member
Author
|
I'm currently targeting |
Member
|
Yeah, this will be a huge improvement in results. I'll hold off on detailed commentary until after pelias/wof-admin-lookup#331 so we can test more fully, but I like how easy this sort of change is to make now. I'm ok with a very limited set of hoisting for now, we could drop empire for sure, and maybe even dependency. Country is really just special because it allows adding |
Member
|
I think we should keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we recently had a report that some WOF records are missing their
countryhierarchy entry, for example Lancingwith the 'hybrid' approach we use for the pelias PIP view, we can take values from the 'pure pip' results and use them when they are not present in the hierarchy.
See 7863cd2 for a succinct diff of the functionality change.