Skip to content

pelias pip - 'hoist' layers from pure pip results if not present in hierarchy#127

Merged
missinglink merged 3 commits intomasterfrom
pip-pelias-missing-parents
Oct 3, 2025
Merged

pelias pip - 'hoist' layers from pure pip results if not present in hierarchy#127
missinglink merged 3 commits intomasterfrom
pip-pelias-missing-parents

Conversation

@missinglink
Copy link
Member

we recently had a report that some WOF records are missing their country hierarchy entry, for example Lancing

Screenshot 2025-09-30 at 15 14 55

with the 'hybrid' approach we use for the pelias PIP view, we can take values from the 'pure pip' results and use them when they are not present in the hierarchy.

See 7863cd2 for a succinct diff of the functionality change.

@missinglink
Copy link
Member Author

I'm currently targeting ['country', 'dependency', 'empire', 'continent'], I wonder if adding region might be a good idea too 🤔

@orangejulius
Copy link
Member

Yeah, this will be a huge improvement in results. I'll hold off on detailed commentary until after pelias/wof-admin-lookup#331 so we can test more fully, but I like how easy this sort of change is to make now.

I'm ok with a very limited set of hoisting for now, we could drop empire for sure, and maybe even dependency. Country is really just special because it allows adding country_codes.

@Joxit
Copy link
Member

Joxit commented Oct 1, 2025

I think we should keep dependency, IIRC dependencies are replacing countries in some parts of the world.

@missinglink missinglink merged commit dec8317 into master Oct 3, 2025
7 checks passed
@missinglink missinglink deleted the pip-pelias-missing-parents branch October 3, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants