Skip to content

chore: bump rute-bayar to v0.1.10#8

Open
wauputr4 wants to merge 1 commit into
mainfrom
chore/rute-bayar-v0.1.10
Open

chore: bump rute-bayar to v0.1.10#8
wauputr4 wants to merge 1 commit into
mainfrom
chore/rute-bayar-v0.1.10

Conversation

@wauputr4

Copy link
Copy Markdown
Member

Automated Homebrew update for release v0.1.10.

  • Bump formula version to 0.1.10
  • Update darwin/linux binary URLs and SHA256 checksums
  • Keeps install command as rutebayar

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the rute-bayar Homebrew formula to version 0.1.10 and updates the SHA256 hashes. However, the changes incorrectly escape the Ruby string interpolation in the download URLs by adding a backslash before the hash symbol. This prevents the version from being interpolated and will cause 404 errors when downloading the binaries. The backslashes should be removed to restore proper string interpolation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Formula/rute-bayar.rb
if Hardware::CPU.arm?
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-arm64"
sha256 "f01ede6cab4b3f432295fd5bd7368701a279bab552094ee1525ca54d5e6dca6e"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-darwin-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby. This will cause the URL to literally contain \#{version} instead of the actual version number, leading to a 404 error when Homebrew attempts to download the binary. Remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-arm64"

Comment thread Formula/rute-bayar.rb
else
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-amd64"
sha256 "a04c56c75bdd92775cdad5aaaa7aa06b521f663523b96bd45a5190478bffa175"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-darwin-amd64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby. This will cause the URL to literally contain \#{version} instead of the actual version number, leading to a 404 error when Homebrew attempts to download the binary. Remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-amd64"

Comment thread Formula/rute-bayar.rb
if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-arm64"
sha256 "aa6aa2a8454192e879da7d2ff4ee97e1b51f5669b11c9f0cfd508a0cffb3896a"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-linux-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby. This will cause the URL to literally contain \#{version} instead of the actual version number, leading to a 404 error when Homebrew attempts to download the binary. Remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-arm64"

Comment thread Formula/rute-bayar.rb
else
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-amd64"
sha256 "a0c7c48fe0467fff629689b5c4df6ad15ebe03a6bd174bdab2110022cc5bdf70"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-linux-amd64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The backslash before the # escapes the string interpolation in Ruby. This will cause the URL to literally contain \#{version} instead of the actual version number, leading to a 404 error when Homebrew attempts to download the binary. Remove the backslash to allow proper string interpolation.

      url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-linux-amd64"

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3f44c3cd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Formula/rute-bayar.rb
if Hardware::CPU.arm?
url "https://github.com/pendig/rute-bayar/releases/download/v#{version}/rutebayar-darwin-arm64"
sha256 "f01ede6cab4b3f432295fd5bd7368701a279bab552094ee1525ca54d5e6dca6e"
url "https://github.com/pendig/rute-bayar/releases/download/v\#{version}/rutebayar-darwin-arm64"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore version interpolation in download URLs

Because the # is escaped here, Ruby treats v\#{version} as a literal string rather than interpolating version; the same pattern is used for all four platform URLs in this formula. Any brew install rute-bayar on macOS or Linux will therefore request GitHub paths containing the literal #{version} and fail with a 404 before checksum verification.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant