Skip to content

feat: enable direct CSS theme overrides [NOVUS-392] #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolson wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: enable direct CSS theme overrides [NOVUS-392] #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c93faa9
feat: enable direct CSS theme overrides with :where() and button refa…
Apr 14, 2026
13acef2
fix: make nested surfaces contrast-safe on any theme
Apr 20, 2026
d438739
fix: render tooltip caret as rotated square that inherits theme backg…
Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/elements/pendo-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,20 @@ class PendoButton extends PendoBaseElement {
}

renderDefault(variant) {
const button = document.createElement('button');
button.type = 'button';
button.className = `pendo-button pendo-button--${variant}`;

// Move inner content to button
button.innerHTML = this.innerHTML;
this.innerHTML = '';
this.appendChild(button);

button.addEventListener('click', () => this.handleClick());
// Style the custom element directly — no inner <button>.
// This allows theme CSS targeting pendo-button to work without
// conflicting with an inner element's styles.
this.classList.add('pendo-button', `pendo-button--${variant}`);
this.setAttribute('role', 'button');
this.setAttribute('tabindex', '0');

this.addEventListener('click', () => this.handleClick());
this.addEventListener('keydown', (e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
this.handleClick();
}
});
}

renderCustom(CustomButton, variant) {
Expand Down
25 changes: 13 additions & 12 deletions src/elements/pendo-close-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,23 @@ class PendoCloseButton extends PendoBaseElement {
}

render() {
const button = document.createElement('button');
button.type = 'button';
button.className = 'pendo-close-button';
button.setAttribute('aria-label', 'Close');
// Style the custom element directly — no inner <button>
this.classList.add('pendo-close-button');
this.setAttribute('role', 'button');
this.setAttribute('tabindex', '0');
this.setAttribute('aria-label', 'Close');
this.textContent = '\u00D7'; // × character

const icon = document.createElement('span');
icon.setAttribute('aria-hidden', 'true');
icon.textContent = '\u00D7'; // × character

button.appendChild(icon);
this.appendChild(button);

button.addEventListener('click', (e) => {
this.addEventListener('click', (e) => {
e.preventDefault();
this.emitAction('dismiss');
});
this.addEventListener('keydown', (e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
this.emitAction('dismiss');
}
});
}
}

Expand Down
Loading