Skip to content

[IN PROGRESS] Fix BRL Details Submission#910

Open
Sharqiewicz wants to merge 21 commits intostagingfrom
861-integrate-the-buysell-form-into-the-widget
Open

[IN PROGRESS] Fix BRL Details Submission#910
Sharqiewicz wants to merge 21 commits intostagingfrom
861-integrate-the-buysell-form-into-the-widget

Conversation

@Sharqiewicz
Copy link
Member

@Sharqiewicz Sharqiewicz commented Oct 30, 2025

🎯 Key Changes

  • Unifies error handling schema
  • Adds Claude Agents and .mcp.json schema for claude

📛 Breaking changes: No

🆙 Dependencies: None

⚙️ Configuration: None

✅ Review Focus Areas

  • Verify BRL form submission works end-to-end in widget integration

@Sharqiewicz Sharqiewicz linked an issue Oct 30, 2025 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for vortexfi ready!

Name Link
🔨 Latest commit 5053bf8
🔍 Latest deploy log https://app.netlify.com/projects/vortexfi/deploys/69664d9113133a00082c2646
😎 Deploy Preview https://deploy-preview-910--vortexfi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 30, 2025

Deploy Preview for vortex-sandbox ready!

Name Link
🔨 Latest commit 5053bf8
🔍 Latest deploy log https://app.netlify.com/projects/vortex-sandbox/deploys/69664d901591870008954f14
😎 Deploy Preview https://deploy-preview-910--vortex-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me overall.

However, there is an issue. When I am on the 'Enter details' page on the widget and click on 'Continue', I get the following error and the page goes blank. Tested for both BRL and EUR onramp.

Uncaught TypeError: Cannot read properties of null (reading 'control')
    at RampSubmitButton (RampSubmitButton.tsx:196:23)
RampSubmitButton	@	RampSubmitButton.tsx:196
<RampSubmitButton>		
SummaryStep	@	index.tsx:83
<SummaryStep>		
WidgetContent	@	index.tsx:65
<WidgetContent>		
Widget	@	index.tsx:29
<Widget>		
Ramp	@	index.tsx:15
<Ramp>		
Main	@	index.tsx:34
<Main>		
App	@	app.tsx:29
<App>		
(anonymous)	@	main.tsx:53

@Sharqiewicz Sharqiewicz changed the title Fix BRL Details Submission [READY] Fix BRL Details Submission Oct 31, 2025
@Sharqiewicz Sharqiewicz self-assigned this Oct 31, 2025
@Sharqiewicz
Copy link
Member Author

The CI is failing because of the validatePublicKey typecheck issues in createQuote router from staging changes.

@ebma
Copy link
Member

ebma commented Nov 18, 2025

@Sharqiewicz could you please resolve the merge conflicts and make sure the CI passes again?

@ebma
Copy link
Member

ebma commented Jan 7, 2026

There seems to be a bug, see screenrecording. I cannot proceed with the check out properly.

deploy-preview-910.mp4

@Sharqiewicz Sharqiewicz changed the title [READY] Fix BRL Details Submission [IN PROGRESS] Fix BRL Details Submission Jan 29, 2026
@ebma ebma reopened this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate the Buy/Sell form into the widget

2 participants

Comments