Flexbox for a full screen remote and metadata for use as an android app#4
Open
johnmccabe wants to merge 7 commits intopenguintutor:masterfrom
johnmccabe:feat/flexbox
Open
Flexbox for a full screen remote and metadata for use as an android app#4johnmccabe wants to merge 7 commits intopenguintutor:masterfrom johnmccabe:feat/flexbox
johnmccabe wants to merge 7 commits intopenguintutor:masterfrom
johnmccabe:feat/flexbox
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, great project been using it daily since first setting up my pi, I just had one minor issue with the way in which the webpage rendered on a phone, thought it was a bit small and would have liked it to be full screen so I switched the page to using flexbox css.
This pr switches to flexbox (simplifies the html a lot) and also adds the metadata required to add the remote page as a full screen app on Android (the same can be done for IOS, didn't get round to that tho).
What do you think?