PMM-15079: fix missing properties migration from timeseries panels#902
Open
fabio-silva wants to merge 3 commits into
Open
PMM-15079: fix missing properties migration from timeseries panels#902fabio-silva wants to merge 3 commits into
fabio-silva wants to merge 3 commits into
Conversation
fabio-silva
requested review from
a team,
Copilot,
matejkubinec and
mattiasimonato
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR fixes a gap in the Graph → TimeSeries panel migration so that legend table sorting settings (sort column + direction) are preserved/restored when migrating legacy Graph panel configurations.
Changes:
- Migrate legacy legend sorting configuration (
sortBy/sortandsortDesc) into TimeSeriesoptions.legend. - Add a legacy-to-TimeSeries mapping helper for legend sort keys.
- Add unit tests to validate sort migration behavior for both
sortByand legacysort.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| public/app/plugins/panel/timeseries/migrations.ts | Migrates legacy legend sorting settings into TimeSeries legend options and adds a helper to map legacy sort keys. |
| public/app/plugins/panel/timeseries/migrations.test.ts | Adds tests covering sort key and sort direction migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matejkubinec
approved these changes
May 19, 2026
mattiasimonato
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-15079
SUBMODULES-4367
Fix panel migration to re-instate default sorting on timeseries panels.
Opened PR upstream as well:
grafana#125137