feat(jenkins-ps3-k8s): generate ps3-clouds from a shared catalog (ADR 0029)#93
Merged
Merged
Conversation
… 0029) - Add resources/jenkins/clouds-catalog (catalog + ps3 overlay) and scripts/render-clouds.py: one generator resolves catalog + per-master overlay into a canonical cloud model and serializes the ps3-clouds JCasC configScript. - Regenerate the ps3-clouds configScript from the catalog. Render-equivalent to the live config: 4 clouds (hetzner + 2 amazonEC2 + eC2Fleet), 70 template/serverTemplate slots, field-for-field identical. The Sprig iamInstanceProfile is preserved (account id stays out of git) and init bodies are byte-faithful. - Add the clouds-render-check drift gate to the just ci validate chain. - Ignore the data-only clouds-catalog dir from yamllint (gated by clouds-render-check). - ADR 0029 records the decision: shared catalog + per-master overlays + dual renderer; Kustomize rejected; dynamic AMI resolution deferred.
nogueiraanderson
force-pushed
the
jenkins-ps3-clouds-templatization
branch
from
81220ac to
ee8eae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
ps3-cloudsJCasC configScript is now generated from a shared catalog (resources/jenkins/clouds-catalog/) plus a per-master overlay, viascripts/render-clouds.py. ADR 0029 records the decision (shared catalog, per-master overlays, a dual JCasC/Groovy renderer, with Kustomize rejected and dynamic AMI resolution deferred).Proof
iamInstanceProfileis preserved, so no account id enters git and the reload is a semantic no-op.just clouds-render-checkdrift gate (invalidate) keeps the catalog and the committed configScript in sync. yaml-lint, helm-render, trivy, actionlint, and zizmor pass.Rollout