ci(jenkins): run the clouds-catalog drift + no-alias check in CI and pre-commit#95
Merged
Merged
Conversation
…pre-commit The clouds-render-check gate (ADR 0029) was only in `just validate`, not the split CI jobs or pre-commit, so it never ran on PRs. Wire it in: - ci.yml: add pyyaml to the yamllint job + a render-clouds.py check step. - .pre-commit-config.yaml: add a local clouds-render-check hook. Catches catalog/configScript drift and YAML anchors/aliases (which break the JCasC reload above 50) before merge, instead of on the live ps3 reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap
clouds-render-checkgate (ADR 0029: catalog vs committed configScript drift + no YAML anchors/aliases) lived only injust validate, not the split CI jobs or pre-commit, so it never ran on PRs. That is why the alias bug (fix(jenkins-ps3-k8s): render ps3-clouds without YAML aliases (JCasC reload) #94) reached the live ps3 reload.Fix
ci.yml: add pyyaml to the yamllint job and arender-clouds.py checkstep..pre-commit-config.yaml: add a localclouds-render-checkhook.