PS-11203 Vector Index Syntax#5987
Open
percona-mhansson wants to merge 2 commits into
Open
Conversation
can test the syntax. The code was cherry-picked from the vector search prototype branch.
are no hooks for this in InnoDB so one has been added in check_engine(). We have to do it fairly early so that table creation in the DD can be nipped in the bud. The string is validated (i.e. parsed) inside the storage engine using a new interface validate_engine_attributes(). Options are parsed again in ha_innobase::open(), which is sligthly wasteful, but likely not a big deal compared to actually building the index. To do: We will still need a hook to handle the case of an already-existing table with invalid SECONDARY_ENGINE_ATTRIBUTE; there are no hooks for this.
percona-mhansson
force-pushed
the
vector-mvp-syntax
branch
from
6563758 to
dbbef24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector syntax PR. The first commit is just a cherry-picked minimum of changes from the prototype branch to make the whole vector meta data exist.