Clean up spaghetti code in ExecutorCheckPerms_hook#660
Open
jeltz wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
+ Coverage 86.31% 86.45% +0.13%
==========================================
Files 3 3
Lines 1345 1344 -1
Branches 218 218
==========================================
+ Hits 1161 1162 +1
+ Misses 87 86 -1
+ Partials 97 96 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
artemgavrilov
approved these changes
Jun 5, 2026
The code in our ExecutorCheckPerms_hook was almost impossible to read so cleaned it up so people can understand it. Some of the changes include: - Use argument names from PostgreSQL - Use REL_LST as array size instead of 20 - Use RELKIND_VIEW instead of 'v' - Reduce the number of scopes - Add a couple of comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in our
ExecutorCheckPerms_hookwas almost impossible to read so cleaned it up so people can understand it. Some of the changes include:REL_LSTas array size instead of20RELKIND_VIEWinstead of'v'