PMM-14911 Alerts page#5259
Draft
matejkubinec wants to merge 26 commits into
Draft
Conversation
…hub.com:percona/pmm into PMM-14911-alerts-page
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5259 +/- ##
==========================================
- Coverage 42.20% 42.15% -0.05%
==========================================
Files 410 540 +130
Lines 41995 44342 +2347
Branches 0 591 +591
==========================================
+ Hits 17723 18693 +970
- Misses 22488 23801 +1313
- Partials 1784 1848 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
8 tasks
Contributor
|
Suggestion: add this #5399 before further reviews Stack order would be: |
…kspector (#5427) * Update pmm_components_and_versions.md * Fix linkspector workflow by provisioning Chrome for puppeteer --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* fix: valkey cluster messages panel use message rate (PMM-14894) Use rate() with $__rate_interval on redis_cluster_messages_*_total counters so the graph is messages/s instead of cumulative totals. Set axis label and unit; clarify panel description. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: theTibi <tkorocz@gmail.com> * PMM-14894 Cleanup dashboard --------- Signed-off-by: theTibi <tkorocz@gmail.com> Co-authored-by: Matej Kubinec <matej.kubinec@3pillarglobal.com> Co-authored-by: Matej Kubinec <32638572+matejkubinec@users.noreply.github.com>
…consistencies (#5328) * feat(settings): extend types, add updateSettings API and useUpdateSettings hook with query invalidation Made-with: Cursor * feat(settings): add Settings page shell with MUI tabs and placeholder forms - Add Settings page with SSH Key, Metrics Resolution, Advanced Settings tabs - Add Settings.messages.ts with all copy from Grafana - Add placeholder form components (to be implemented in next commits) - Fix useUpdateSettings onSuccess signature for react-query v5 - Fix updateSnoozeDuration optional handling in useSnooze Made-with: Cursor * feat(settings): implement SSH Key form with react-hook-form and useUpdateSettings Made-with: Cursor * feat(settings): implement Metrics Resolution form with react-hook-form Made-with: Cursor * feat(settings): implement Advanced Settings form with react-hook-form Made-with: Cursor * feat(settings): add /settings route, update Configuration menu and PMM_SETTINGS_URL Made-with: Cursor * fix(settings): resolve useMemo exhaustive-deps lint; add Settings loading test Made-with: Cursor * feat: smaller improvements * fix: tooltips on advanced page * feat: update imports, use types files, run formatter * PMM-14930 Send updated settings event * Enhanced layout behaviors to make settings better - Updated esbuild packages in yarn.lock from version 0.21.5 to 0.25.12. - Added scrollbar stability in GlobalStyles for improved UI experience. - Refactored Page component layout to ensure proper flex behavior and added a Divider for better separation of the footer. - Enhanced Sidebar component for better usability on narrow screens, so now it overlaps, instead of pushing, to open it in smaller screens. * Improved layout in Settings' Metrics Resolution tab - Promoted Metrics resolution as the 1st tab. - Updated text capitalization in Settings.messages. - Improved layout and styling in MetricsResolutionForm for better accessibility. - Transformed the MetricsResolutionForm into inline info, for better accessibility. * Enhance Settings UI and improve user experience - Updated tooltip texts and labels in Settings.messages for clarity. - Refined layout and styling in AdvancedSettingsForm and SshKeyForm for better accessibility and usability. - Added a sticky footer to all tabs for improved action visibility during form submission. - Adjusted spacing and alignment in various components to enhance overall UI consistency. * Fixed surfaces colors and how it's applied to pages - Added a new 'surface' prop to the Page component for customizable background styling. - Integrated GlobalStyles to manage background color based on the 'surface' prop. - Updated Settings page to utilize the new 'surface' prop for improved visual consistency. * Refactor Settings test to remove MemoryRouter * PMM-14852 Fix Mongodb InMemory dashboard (#5219) * Bump golang.org/x/sys from 0.42.0 to 0.43.0 (#5228) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.42.0 to 0.43.0. - [Commits](golang/sys@v0.42.0...v0.43.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.43.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * PMM-14944 Upgrade VictoriaMetrics to v1.139.0 (#5218) * PMM-14980 Fix the healthcheck (#5227) * PMM-14980 Fix the healthcheck * PMM-14980 Optimize the logs * PMM-14980 Replace assert with require for higher reliability * PMM-14980 Fix API test workflow * PMM-14930 Refactor sidebar collapsing * PMM-14930 Update settings messages * PMM-14930 Prevent navigation from grafana when on pmm ui page * PMM-14930 Update percona-ui package * PMM-14930 Correctly handle navitem clicks * PMM-14930 Use form components from percona-ui * PMM-14930 Use zod for validation for metrics resolution * PMM-14930 Use zod for ssh key validation * PMM-14930 Use zod for advanced settings validation * PMM-14930 Run lint & format * PMM-14930 Refactoring and fixes * PMM-14930 Revert some changes * PMM-14930 Cleanup settings payload * PMM-14930 Use toPayload util function * PMM-14930 Run lint & format * PMM-14930 Use messages file * PMM-14930 Correctly handle settings in readonly * PMM-14930 Use constant for feature management fields * PMM-7 - PMM's AI-agent documentation housekeeping (#5298) * PMM-7 - Cross AI agents optimization housekeeping * Update .gitignore Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com> * PMM-7 remove the symlink * PMM-7 Add back managed/AGENTS.md * removing team skills in favor of personal freedom --------- Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com> Co-authored-by: Alex Demidoff <a@demidoff.me> * PMM-14930 Use same settings urls as previously * PMM-14930 Add fallback for old settings page * PMM-14930 Fix unit test * PMM-14930 Improve settings redirection * PMM-14995 Update existing PMM branding assets and styles (#5292) * PMM-14995 Update existing PMM branding assets and styles * PMM-14995 Bump percona-ui library * PMM-14995 Update favicon * Remove stray node_modules symlink --------- Co-authored-by: freenandes <uuuuurso@gmail.com> Co-authored-by: Matej Kubinec <matej.kubinec@3pillarglobal.com> Co-authored-by: Matej Kubinec <32638572+matejkubinec@users.noreply.github.com> Co-authored-by: Fábio Silva <ffjs1993@gmail.com> * PMM-15046 Move NavItem component to percona-ui and fix PMM sidebar inconsistencies * PMM-14930 Fix redirect without tab info * Micro adjustement to a misalignment through padding * PMM-14930 Add additional data testisds to better match previous settings page * PMM-14930 Better align behaviour with old settings page * Minor visual tweak on toggle spacing. Non-breaking * PMM-15046 Bump @percona/percona-ui to 1.0.17 for upstream NavItem * PMM-15046 Update SidebarNavItem tests for upstream NavItem contract - Wrap renders with ThemeContextProvider/pmmThemeOptions: the upstream NavItem consumes the menuText typography variant from the percona-ui theme, which the bare MemoryRouter wrap did not provide. - Replace getByTestId('navitem-dot') with querySelector('.MuiBadge-dot'): NavItemDot was removed in favor of MUI's Badge variant="dot". --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Matej Kubinec <matej.kubinec@3pillarglobal.com> Co-authored-by: Matej Kubinec <32638572+matejkubinec@users.noreply.github.com> Co-authored-by: freenandes <uuuuurso@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com> Co-authored-by: ondrej.patocka <80347071+ondrejpatocka@users.noreply.github.com> Co-authored-by: Alex Demidoff <a@demidoff.me> Co-authored-by: Fábio Silva <ffjs1993@gmail.com> Co-authored-by: Mattia Simonato <mattia.simonato@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14911
SUBMODULES-4302
Screenshots: