Skip to content

PMM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default#5389

Open
ondrejpatocka wants to merge 4 commits into
v3from
PMM-15076---Unable-to-list-all-the-Numa-Nodes-in-NUMA-Details-Graph
Open

PMM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default#5389
ondrejpatocka wants to merge 4 commits into
v3from
PMM-15076---Unable-to-list-all-the-Numa-Nodes-in-NUMA-Details-Graph

Conversation

@ondrejpatocka
Copy link
Copy Markdown
Contributor

@ondrejpatocka ondrejpatocka commented May 20, 2026

Problem

  • node variable shipped as single-value, hidden, defaulting to 0 - so per-node rows
    ("repeat": "node") only rendered for Node 0 on multi-NUMA hosts.
  • Contradicts the user manual: "For each node, this dashboard shows metrics…".

Changes (dashboards/OS/NUMA_Details.json)

  • node variable → multi: true, includeAll: true, hide: 0, default $__all
    (now consistent with the sibling zone variable).
  • 26 panel queries: node="$node"node=~"$node" to match the regex substitution
    produced by a multi-value variable.

@ondrejpatocka ondrejpatocka self-assigned this May 20, 2026
@ondrejpatocka ondrejpatocka added the author:ai-hybrid Human and AI co-authored contribution label May 20, 2026
@ondrejpatocka ondrejpatocka changed the title MM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default PMM-15076 Fix NUMA Details dashboard to show all NUMA nodes by default May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.97%. Comparing base (d2ea72b) to head (2dccf5e).
⚠️ Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #5389      +/-   ##
==========================================
- Coverage   43.21%   42.97%   -0.25%     
==========================================
  Files         413      543     +130     
  Lines       42282    44482    +2200     
  Branches        0      591     +591     
==========================================
+ Hits        18274    19117     +843     
- Misses      22139    23434    +1295     
- Partials     1869     1931      +62     
Flag Coverage Δ
admin 34.94% <ø> (ø)
unittests 41.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ondrejpatocka ondrejpatocka marked this pull request as ready for review June 2, 2026 11:53
@ondrejpatocka ondrejpatocka requested review from a team and Nailya as code owners June 2, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:ai-hybrid Human and AI co-authored contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants