Skip to content

PS-11159 [DOCS] - document OpenID Connect (OIDC) authentication 8.4#718

Open
patrickbirch wants to merge 1 commit into
8.4from
ps-11159-8.4
Open

PS-11159 [DOCS] - document OpenID Connect (OIDC) authentication 8.4#718
patrickbirch wants to merge 1 commit into
8.4from
ps-11159-8.4

Conversation

@patrickbirch
Copy link
Copy Markdown
Collaborator

modified:   docs/authentication-methods.md
new file:   docs/openid-connect-authentication.md
modified:   mkdocs-base.yml

Comment thread docs/authentication-methods.md Outdated
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md Outdated
Copy link
Copy Markdown
Collaborator

@jankowsk jankowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!
Few comments.
Proxying and telemetry to be added later

Copy link
Copy Markdown
Collaborator

@jankowsk jankowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that in general 👍
Proxying complicates things as it introduces tree of possibilities, I know... I pointed out a few things that may be a bit confusing, also I think it is worth to expose that feature as it may be very useful and it is one that distinguish us from the upstream. Please treat my comments as suggestions that you may modify or reject.

Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md
Comment thread docs/openid-connect-authentication.md Outdated
Comment thread docs/openid-connect-authentication.md Outdated
Copy link
Copy Markdown
Collaborator

@jankowsk jankowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me , thanks :)

Comment thread docs/openid-connect-authentication.md
	modified:   docs/authentication-methods.md
	new file:   docs/openid-connect-authentication.md
	modified:   mkdocs-base.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants