Update security scan workflow with new steps - #46
Open
martinrvisser wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structure
Added name, on (push/PR to main), and wrapped job in jobs: key
Supply-chain hardening
Trivy installed via pinned release URL (0.51.1) + wget, no script pipes
Version check with trivy --version after install
Full commit SHAs on GitHub Actions (checkout, SARIF upload)
Efficiency
Single Trivy scan combining --format sarif --exit-code 1 (no redundant runs)
Scanning src/ only with trivy fs (not entire filesystem)
Removed noisy skip-dirs
Build gating
Trivy scan fails the build if CRITICAL/HIGH found (exit code 1)
Cppcheck errors explicitly fail with exit 1
SARIF still uploads via if: always() even on failure
Observability
Cppcheck results written to file and displayed
Error annotation in logs if Cppcheck finds issues
Clear success/fail output