Making PCP a bit friendlier to AI agents#2583
Conversation
|
Would it make sense, as part of this PR, to rename CLAUDE.md to AGENTS.md ? |
|
@kurik yes it would IMO - Claude doesn't read that though, so what I see other projects doing (e.g. vllm) is to create a CLAUDE.md that contains: |
|
@kurik and @natoscott, the AgentReady CLAUDEmdAssessor class does accept a |
I do not have any strong opinion, not even experience, here. My personal preference would be to have only the |
| @@ -0,0 +1,60 @@ | |||
| name: Performance Co-Pilot Issue Report | |||
| description: Create a report for a PCP related issues on Linux | |||
| title: "[Issue] " | |||
There was a problem hiding this comment.
Does adding "[Issue]" to every non-RFE issue really help in any way? I'd prefer to leave the title string as was originally provided if not.
There was a problem hiding this comment.
Yes, "[Issue]" is too generic. Looking at how the papi issues which this was based on there are two templates described it .github/ISSUE_TEMPLATE but there is a third "Blank issue" choice when filing a new issue. Maybe it would be better to this called a bug template for PCP.
There was a problem hiding this comment.
I did some fixup to make the issue template a more descriptive bug template. I also collected up the patches and put them on an updated checkout of pcp git repo branch.
When LC_ALL is set in the caller's environment (e.g. LC_ALL=en_US.utf8), it overrides any per-command LC_COLLATE=POSIX setting used inside individual QA tests, causing locale-sensitive sort ordering instead of the expected POSIX byte-value ordering. This manifests as spurious output mismatches in tests such as 821/1663 where metric names are enumerated via "LC_COLLATE=POSIX sort". Unsetting LC_ALL at the start of the check script removes the inherited override while still allowing individual tests to apply their own per-command locale settings (e.g. "LC_COLLATE=en_US.utf8 sort") as intended by their authors.
…al docs Make it a bit simpler for people (and AI) directly looking at the git repository README.md to get started installing and building PCP and locating the documentation.
Some times people forget to include details when filing issues on github. The template should encourage people to include additional pieces of information that would be useful in addressing the issues.
The |
|
@tallpsmith Any suggested changes to the patches? Or is this good to be merged into upstream? |
4 participants
The AgentReady tooling reviews a git repository and suggest changes to make it easier for AI agents to navigate and improve the overall processes for development for the code in the git repository. AgentReady scores the results. The initial assessment of PCP was towards the bottom of the Bronze (42.5). The patches in this merge request provides:
These changes moves PCP's accessment to the middle of the Bronze (51.8). There are some other areas for improvement flagged by AgentReady that are not yet addressed: